8000 Change checks for rexec and rlogin to use xinetd configuration by teacup-on-rockingchair · Pull Request #13185 · ComplianceAsCode/content · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Change checks for rexec and rlogin to use xinetd configuration #13185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 27, 2025
Merged

Change checks for rexec and rlogin to use xinetd configuration #13185

merged 4 commits into from
Mar 27, 2025

Conversation

teacup-on-rockingchair
Copy link
Contributor

Description:

  • Add template for xinetd service disable and use it for rexec and rlogin

Rationale:

  • For SLE15 platform where rexec and rlogin are enabled via xinetd use new template that checks/disables service in xinetd super-daemon

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Mar 16, 2025
@openshift-ci OpenShift CI
Copy link
openshift-ci bot commented Mar 16, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@teacup-on-rockingchair teacup-on-rockingchair added Ansible Ansible remediation update. OVAL OVAL update. Related to the systems assessments. Bash Bash remediation update. SLES SUSE Linux Enterprise Server product related. New Template Issues or pull requests related to new Templates. labels Mar 16, 2025
@teacup-on-rockingchair teacup-on-rockingchair added this to the 0.1.77 milestone Mar 16, 2025
@teacup-on-rockingchair teacup-on-rockingchair marked this pull request as ready for review March 17, 2025 07:35
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Mar 17, 2025
Mab879
Mab879 requested changes Mar 24, 2025
View reviewed changes
Copy link
Member
@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR.

I have a couple of suggestions.

teacup-on-rockingchair and others added 2 commits March 25, 2025 12:05
@teacup-on-rockingchair @Mab879
Update shared/templates/xinetd_service_disabled/ansible.template
a923e8a 
Co-authored-by: Matthew Burket <m@tthewburket.com>
@teacup-on-rockingchair @Mab879
Update shared/templates/xinetd_service_disabled/ansible.template
4126494 
Co-authored-by: Matthew Burket <m@tthewburket.com>
@codeclimate CodeClimate
Copy link
codeclimate bot commented Mar 25, 2025

Code Climate has analyzed commit 4126494 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 1

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.9% (0.0% change).

View more on Code Climate.

@Mab879
Copy link
Member
Mab879 commented Mar 26, 2025

/packit build

@Mab879
Copy link
Member
Mab879 commented Mar 27, 2025

The automatus failures are expected due to packages not being in UBI8 or the rule not being in benchamrks.

@Mab879 Mab879 merged commit 42afa19 into ComplianceAsCode:master Mar 27, 2025
105 of 110 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mab879 Mab879 Mab879 approved these changes

Assignees

@Mab879 Mab879

@teacup-on-rockingchair teacup-on-rockingchair

Labels
Ansible Ansible remediation update. Bash Bash remediation update. New Template Issues or pull requests related to new Templates. OVAL OVAL update. Related to the systems assessments. SLES SUSE Linux Enterprise Server product related.
Projects
None yet
Milestone
0.1.77
Development

Successfully merging this pull request may close these issues.
2 participants
@teacup-on-rockingchair @Mab879
0