8000 Revert the uid back to rsyslog for the rule file_owner_var_log_syslog by alanmcanonical · Pull Request #13169 · ComplianceAsCode/content · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Revert the uid back to rsyslog for the rule file_owner_var_log_syslog #13169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2025
Merged

Revert the uid back to rsyslog for the rule file_owner_var_log_syslog #13169

merged 1 commit into from
Mar 13, 2025

Conversation

alanmcanonical
Copy link
Contributor
@alanmcanonical alanmcanonical commented Mar 12, 2025 •
edited
Loading
8000

Description:

  • Change the uid of rule file_owner_var_log_syslog back to syslog
  • Make customized tests only applicable on Ubuntu

Rationale

  • The uid required by stig for Ubuntu 20.04 and 22.04 is syslog

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Mar 12, 2025
@openshift-ci OpenShift CI
Copy link
openshift-ci bot commented Mar 12, 2025

Hi @alanmcanonical. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-actions GitHub Actions
Copy link
github-actions bot commented Mar 12, 2025 •
edited
Loading

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff 
New content has different text for rule 'xccdf_org.ssgproject.content_rule_file_owner_var_log_syslog'.
--- xccdf_org.ssgproject.content_rule_file_owner_var_log_syslog
+++ xccdf_org.ssgproject.content_rule_file_owner_var_log_syslog
@@ -4,7 +4,7 @@
 
 [description]:
 To properly set the owner of /var/log/syslog, run the command:
-$ sudo chown root /var/log/syslog
+$ sudo chown syslog /var/log/syslog
 
 [reference]:
 CCI-001314

OCIL for rule 'xccdf_org.ssgproject.content_rule_file_owner_var_log_syslog' differs.
--- ocil:ssg-file_owner_var_log_syslog_ocil:questionnaire:1
+++ ocil:ssg-file_owner_var_log_syslog_ocil:questionnaire:1
@@ -2,6 +2,6 @@
 run the command:
 $ ls -lL /var/log/syslog
 If properly configured, the output should indicate the following owner:
-root
-      Is it the case that /var/log/syslog does not have an owner of root?
+syslog
+      Is it the case that /var/log/syslog does not have an owner of syslog?

@alanmcanonical alanmcanonical force-pushed the correct_uid branch 2 times, most recently from afa96fd to 902ef70 Compare March 12, 2025 13:51
@alanmcanonical alanmcanonical marked this pull request as draft March 12, 2025 14:31
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Mar 12, 2025
@alanmcanonical
The original uid was '104' which should represent syslog on Ubuntu focal
8d6cef7 
and jammy
Made the customized tests only applicable on Ubuntu to avoid unnecessary
template test override for other distros (if there is any)
@alanmcanonical alanmcanonical changed the title Revert the uid back to root for the rule file_owner_var_log_syslog of other distros Revert the uid back to rsyslog for the rule file_owner_var_log_syslog Mar 12, 2025
@codeclimate CodeClimate
Copy link
codeclimate bot commented Mar 12, 2025

Code Climate has analyzed commit 8d6cef7 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 62.0% (0.0% change).

View more on Code Climate.

@alanmcanonical alanmcanonical marked this pull request as ready for review March 12, 2025 15:55
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Mar 12, 2025
@alanmcanonical
Copy link
Contributor Author

@dodys Please have a look

@Mab879 Mab879 added this to the 0.1.77 milestone Mar 12, 2025
@Mab879 Mab879 added the Update Rule Issues or pull requests related to Rules updates. label Mar 12, 2025
mpurg
mpurg approved these changes Mar 13, 2025
View reviewed changes
Copy link
Contributor
@mpurg mpurg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks

@dodys dodys self-assigned this Mar 13, 2025
@dodys dodys added the Ubuntu Ubuntu product related. label Mar 13, 2025
dodys
dodys approved these changes Mar 13, 2025
View reviewed changes
Copy link
Contributor
@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit e78ec5a into ComplianceAsCode:master Mar 13, 2025
101 of 102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dodys dodys dodys approved these changes

@mpurg mpurg mpurg approved these changes

Assignees

@dodys dodys

Labels
needs-ok-to-test Used by openshift-ci bot. Ubuntu Ubuntu product related. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Milestone
0.1.77
Development

Successfully merging this pull request may close these issues.
4 participants
@alanmcanonical @dodys @mpurg @Mab879
0