8000 Apply 1.1.1.8 to server_l1 to match the benchmark on RHEL 8 by jeepingben · Pull Request #13103 · ComplianceAsCode/content · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Apply 1.1.1.8 to server_l1 to match the benchmark on RHEL 8 #13103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 25, 2025
Merged

Apply 1.1.1.8 to server_l1 to match the benchmark on RHEL 8 #13103

merged 2 commits into from
Feb 25, 2025

Conversation

jeepingben
Copy link
Contributor

Description:

  • Apply kernel_module_usb-storage_disabled to l1_server to match the benchmark

Rationale:

Review Hints:

@jeepingben jeepingben requested a review from a team as a code owner February 25, 2025 18:19
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Feb 25, 2025
@openshift-ci OpenShift CI
Copy link
openshift-ci bot commented Feb 25, 2025

Hi @jeepingben. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Mab879 Mab879 added this to the 0.1.77 milestone Feb 25, 2025
@Mab879 Mab879 changed the title Apply 1.1.1.8 to server_l1 to match the benchmark Apply 1.1.1.8 to server_l1 to match the benchmark on RHEL 8 Feb 25, 2025
@Mab879 Mab879 added Update Profile Issues or pull requests related to Profiles updates. RHEL8 Red Hat Enterprise Linux 8 product related. CIS CIS Benchmark related. labels Feb 25, 2025
@Mab879 Mab879 self-assigned this Feb 25, 2025
Mab879
Mab879 requested changes Feb 25, 2025
View reviewed changes
controls/cis_rhel8.yml
@@ -106,7 +106,7 @@ controls:
- id: 1.1.1. 8000 8
title: Ensure usb-storage kernel module is not available (Automated)
levels:
- l2_server
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the profile stability tests. If you run ctest --output-on-failure from build folder once the RHEL 8 product is built you will get more information.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, that should be fixed

@codeclimate CodeClimate
Copy link
codeclimate bot commented Feb 25, 2025

Code Climate has analyzed commit e820ecf and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 62.0% (0.0% change).

View more on Code Climate.

Mab879
Mab879 approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member
@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@Mab879 Mab879 merged commit efea6a8 into ComplianceAsCode:master Feb 25, 2025
101 of 102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mab879 Mab879 Mab879 approved these changes

Assignees

@Mab879 Mab879

Labels
CIS CIS Benchmark related. needs-ok-to-test Used by openshift-ci bot. RHEL8 Red Hat Enterprise Linux 8 product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Milestone
0.1.77
4395
Development

Successfully merging this pull request may close these issues.

usb-storage_disabled removed from RHEL8 cis server l1
2 participants
@jeepingben @Mab879
0