8000 [ubuntu2404] New rule: remove pkg inetutils-telnet by alanmcanonical · Pull Request #13095 · ComplianceAsCode/content · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[ubuntu2404] New rule: remove pkg inetutils-telnet #13095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 26, 2025
Merged

[ubuntu2404] New rule: remove pkg inetutils-telnet #13095

merged 3 commits into from
Feb 26, 2025

Conversation

alanmcanonical
Copy link
Contributor
@alanmcanonical alanmcanonical commented Feb 24, 2025 •
edited
Loading

Description:

  • Implement a new 8000 rule to remove pkg inetutils-telnet

Rationale:

  • telnet is a transitional dummy package for inetutils-telnet default switch
  • Satisfy rule 2.2.4 Ensure telnet client is not installed which requires inetutils-telnet & telnet are not installed

@alanmcanonical alanmcanonical requested a review from a team as a code owner February 24, 2025 12:01
@openshift-ci OpenShift CI
Copy link
openshift-ci bot commented Feb 24, 2025

Hi @alanmcanonical. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Feb 24, 2025
@alanmcanonical
Copy link
Contributor Author

@dodys please have a look

dodys
dodys requested changes Feb 24, 2025
View reviewed changes
Copy link
Contributor
@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see ctest failure:
https://github.com/ComplianceAsCode/content/actions/runs/13497522246/job/37708028250?pr=13095

@dodys dodys self-assigned this Feb 24, 2025
@dodys dodys added Ubuntu Ubuntu product related. New Rule Issues or pull requests related to new Rules. CIS CIS Benchmark related. labels Feb 24, 2025
@dodys dodys added this to the 0.1.77 milestone Feb 24, 2025
@mpurg
Copy link
Contributor
mpurg commented Feb 24, 2025

It needs to be in both components:

Rule 'package_inetutils-telnet_removed' must be assigned to component 'inetutils-telnet', because rule uses template 'package_removed' with 'pkgname' parameter set to 'inetutils-telnet' which is a package that already belongs to component 'inetutils-telnet'.
Rule 'package_inetutils-telnet_removed' must be in component 'telnet' because it's a member of 'telnet' group.

@codeclimate CodeClimate
Copy link
codeclimate bot commented Feb 25, 2025

Code Climate has analyzed commit f4e4101 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 62.0% (0.0% change).

View more on Code Climate.

dodys
dodys approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor
@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit fd624a7 into ComplianceAsCode:master Feb 26, 2025
95 of 102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dodys dodys dodys approved these changes

Assignees

@dodys dodys

Labels
CIS CIS Benchmark related. needs-ok-to-test Used by openshift-ci bot. New Rule Issues or pull requests related to new Rules. Ubuntu Ubuntu product related.
Projects
None yet
Milestone
0.1.77
Development

Successfully merging this pull request may close these issues.
3 participants
@alanmcanonical @mpurg @dodys
0