-
Notifications
You must be signed in to change notification settings - Fork 745
SLE Add dependency to crypto-policies-scripts package #13088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SLE Add dependency to crypto-policies-scripts package #13088
Conversation
…ipts package for SLE platform
Skipping CI for Draft Pull Request. |
This datastream diff is auto generated by the check Click here to see the full diffbash remediation for rule 'xccdf_org.ssgproject.content_rule_configure_crypto_policy' differs.
--- xccdf_org.ssgproject.content_rule_configure_crypto_policy
+++ xccdf_org.ssgproject.content_rule_configure_crypto_policy
@@ -1,5 +1,7 @@
var_system_crypto_policy=''
+
+
stderr_of_call=$(update-crypto-policies --set ${var_system_crypto_policy} 2>&1 > /dev/null) |
Code Climate has analyzed commit 051a760 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 62.0% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have discovered a suspicious fail in Automatus on RHEL 9 with Ansible Remediations.
jcerny@fedora:~/work/git/scap-security-guide (pr/13088)$ python3 tests/automatus.py rule --libvirt qemu:///system ssgts_rhel9 --remediate-using ansible --scenario policy_default_cis_l1.pass.sh configure_crypto_policy
Setting console output to log level INFO
INFO - The base image option has not been specified, choosing libvirt-based test environment.
INFO - Logging into /home/jcerny/work/git/scap-security-guide/logs/rule-custom-2025-02-20-1747/test_suite.log
INFO - xccdf_org.ssgproject.content_rule_configure_crypto_policy
INFO - Script policy_default_cis_l1.pass.sh using profile xccdf_org.ssgproject.content_profile_cis_server_l1 OK
ERROR - Script policy_default_cis_l1.pass.sh using profile xccdf_org.ssgproject.content_profile_cis_workstation_l1 found issue:
ERROR - Rule xccdf_org.ssgproject.content_rule_configure_crypto_policy has not been evaluated! Wrong profile selected in test scenario or there has been problem starting the evaluation. Please inspect the log file /home/jcerny/work/git/scap-security-guide/logs/rule-custom-2025-02-20-1747/configure_crypto_policy-policy_default_cis_l1.pass.sh-initial.verbose.log for details.
ERROR - The initial scan failed for rule 'xccdf_org.ssgproject.content_rule_configure_crypto_policy'.
This doesn't happen for me with the current upstream master. That indicates it could be caused by this PR. I will try to investigate what is going on there.
Thanks will check it on my local setup also |
@teacup-on-rockingchair I spent quite a lot of time with this and I discovered that it isn't reproducible deterministically. It happens only sometimes. Also, today I'm able to get this error also with the current upstream master and also it fails with the latest release tag. That means the problem isn't caused by contents of this PR. I think it's somehow related to how Automatus works with VMs and VM snapshots. There is a snapshot revert done between executing of each scenarios. Perhaps it tries to connect to the VM before it starts. |
Description:
Rationale: