10000 [Stabilization] handle rules trying to remove no longer existing packages by vojtapolasek · Pull Request #11353 · ComplianceAsCode/content · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Stabilization] handle rules trying to remove no longer existing packages #11353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

vojtapolasek
Copy link
Collaborator

Description:

  • add warnings to rules which try to remove no longer existing packages in RHEL 8 and RHEL 9
  • remove such rules from RHEL 8 and RHEL 9 PCI-DSS profiles

Rationale:

These rules will pass because no such package will be installed, but they cause problems during Automatus running in combined mode because test scenarios are trying to install those packages and they fail.

Review Hints:

  • Review hints here. Replace this text. Don't use the italics format!

  • Use this optional section to give any relevant information which could help the reviewer to more quickly and assertively understand and test the changes.

  • Good examples are useful commands, if it is better to review all commits together or in a suggested sequence, any relevant discussion in other PRs or issues, etc.

@vojtapolasek vojtapolasek added the backported-into-stabilization PRs which were cherry-picked during stabilization process. label Dec 6, 2023
@vojtapolasek vojtapolasek added this to the 0.1.71 milestone Dec 6, 2023
@vojtapolasek vojtapolasek requested a review from a team as a code owner December 6, 2023 13:23
Copy link
github-actions bot commented Dec 6, 2023

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link
github-actions bot commented Dec 6, 2023

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff
New content has different text for rule 'xccdf_org.ssgproject.content_rule_package_rsh-server_removed'.
--- xccdf_org.ssgproject.content_rule_package_rsh-server_removed
+++ xccdf_org.ssgproject.content_rule_package_rsh-server_removed
@@ -6,6 +6,9 @@
 The rsh-server package can be removed with the following command:
 
 $ sudo yum erase rsh-server
+
+[warning]:
+The package is not available in Red Hat Enterprise Linux 8.
 
 [reference]:
 BP28(R1)

New content has different text for rule 'xccdf_org.ssgproject.content_rule_package_rsh_removed'.
--- xccdf_org.ssgproject.content_rule_package_rsh_removed
+++ xccdf_org.ssgproject.content_rule_package_rsh_removed
@@ -6,6 +6,9 @@
 The rsh package contains the client commands
 
 for the rsh services
+
+[warning]:
+The package is not available in Red Hat Enterprise Linux 8.
 
 [reference]:
 BP28(R1)

New content has different text for rule 'xccdf_org.ssgproject.content_rule_package_talk-server_removed'.
--- xccdf_org.ssgproject.content_rule_package_talk-server_removed
+++ xccdf_org.ssgproject.content_rule_package_talk-server_removed
@@ -4,6 +4,9 @@
 
 [description]:
 The talk-server package can be removed with the following command:  $ sudo yum erase talk-server
+
+[warning]:
+The package is not available in Red Hat Enterprise Linux 8.
 
 [reference]:
 BP28(R1)

New content has different text for rule 'xccdf_org.ssgproject.content_rule_package_talk_removed'.
--- xccdf_org.ssgproject.content_rule_package_talk_removed
+++ xccdf_org.ssgproject.content_rule_package_talk_removed
@@ -10,6 +10,9 @@
 The talk package can be removed with the following command:
 
 $ sudo yum erase talk
+
+[warning]:
+The package is not available in Red Hat Enterprise Linux 8.
 
 [reference]:
 BP28(R1)

@vojtapolasek vojtapolasek changed the title handle rules trying to remove no longer existing packages [Stabilization] handle rules trying to remove no longer existing packages Dec 6, 2023
for packages which no longer exist in rhel8 a/ rhel9
@vojtapolasek vojtapolasek force-pushed the remove_obsolete_packages_from_pcidss_stabilizaton branch from 6f337fa to d6041d0 Compare December 6, 2023 13:34
@Mab879 Mab879 self-assigned this Dec 6, 2023
@Mab879
Copy link
Member
Mab879 commented Dec 6, 2023

/packit rebuild-failed

Copy link
Member
@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The automatus failures are expect due to non-existent packages.

@Mab879 Mab879 merged commit 459f0ab into ComplianceAsCode:stabilization-v0.1.71 Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported-into-stabilization PRs which were cherry-picked during stabilization process.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0