8000 comfy standalone: numpy < 2.0 for all OS by robinjhuang · Pull Request #202 · Comfy-Org/comfy-cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

comfy standalone: numpy < 2.0 for all OS #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Faile 10000 d to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions comfy_cli/uv.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,8 @@
from typing import Any, Optional, Union, cast

from comfy_cli import ui
from comfy_cli.constants import GPU_OPTION, OS
from comfy_cli.constants import GPU_OPTION
from comfy_cli.typing import PathLike
from comfy_cli.utils import get_os


def _run(cmd: list[str], cwd: PathLike, check: bool = True) -> subprocess.CompletedProcess[Any]:
Expand Down Expand Up @@ -406,8 +405,6 @@ def make_override(self):
f.write(DependencyCompiler.overrideGpu.format(gpu=self.gpu, gpuUrl=self.gpuUrl))
f.write("\n\n")

# TODO: remove numpy<2 override once torch is compatible with numpy>=2
if get_os() == OS.WINDOWS:
f.write("numpy<2\n")
f.write("\n\n")

Expand Down
2 changes: 1 addition & 1 deletion tests/uv/mock_requirements/requirements.compiled
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ mpmath==1.3.0
# -r /home/tel/git/comfy-cli/tests/uv/mock_requirements/y_reqs.txt
# sympy
# from https://download.pytorch.org/whl/rocm6.1
numpy==2.0.0
numpy==1.26.4
# via
# --override override.txt
# -r /home/tel/git/comfy-cli/tests/uv/mock_requirements/x_reqs.txt
Expand Down
Loading
0