8000 Fixed parameter order by Dawider10 · Pull Request #4354 · CommunityToolkit/WindowsCommunityToolkit · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixed parameter order #4354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2021
Merged

Fixed parameter order #4354

merged 1 commit into from
Nov 2, 2021

Conversation

Dawider10
Copy link
Contributor

Fixes

Fixed order of Delay and Duration parameters in a call to CreateDoubleAnimation inside of XamlTransformDoubleAnimationFactory.GetAnimation.

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Delay parameter sets duration and vice versa.

What is the new behavior?

Delay parameter sets delay and duration parameter sets duration.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
    • If control, added to Visual Studio Design project
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link
ghost commented Oct 30, 2021

Thanks Dawider10 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker and azchohfi October 30, 2021 01:58
Sergio0694
Sergio0694 approved these changes Nov 2, 2021
View reviewed changes
Copy link
Member
@Sergio0694 Sergio0694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! Thanks @Dawider10! 🙌

@Sergio0694 Sergio0694 merged commit bdd1d84 into CommunityToolkit:main Nov 2, 2021
@michael-hawker michael-hawker added this to the 7.2/8.0? milestone Nov 2, 2021
@michael-hawker michael-hawker added bug 🐛 An unexpected issue that highlights incorrect behavior animations 🏮 labels Nov 2, 2021
@michael-hawker michael-hawker modified the milestones: 8.0, 7.1.3 Jul 14, 2022
@michael-hawker michael-hawker modified the milestones: 7.1.3, 7.1.2 Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sergio0694 Sergio0694 Sergio0694 approved these changes

@XAML-Knight XAML-Knight XAML-Knight approved these changes

@michael-hawker michael-hawker Awaiting requested review from michael-hawker

@azchohfi azchohfi Awaiting requested review from azchohfi

Assignees
No one assigned
Labels
animations 🏮 bug 🐛 An unexpected issue that highlights incorrect behavior hotfix 🌶
Projects
None yet
Milestone
7.1.2
Development

Successfully merging this pull request may close these issues.
4 participants
@Dawider10 @Sergio0694 @XAML-Knight @michael-hawker
0