Aspect Ratio: Add implicit converter for integer #4321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks XAML-Knight for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
11 tasks
| <Project>{84ab7dc5-95c9-4cf8-a370-d077e9e9ef1a}</Project> | ||
| <Name>Microsoft.Toolkit.Uwp.UI.Controls.Primitives</Name> | ||
| </ProjectReference> | ||
| <ProjectReference Include="..\..\Microsoft.Toolkit.Uwp.UI.Controls\Microsoft.Toolkit.Uwp.UI.Controls.csproj"> |
There was a problem hiding this comment.
shouldn't need the controls package here as it just contains all the other packages (it has nothing in it itself).
michael-hawker
approved these changes
Oct 14, 2021
michael-hawker
approved these changes
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4241
PR Type
If you try and bind an
intvalue to theAspectRatioof theConstrainedBoxthen it won't convert as it can't cast it to double... Should provide implicit converters forintin addition todoubleto help this scenario where you want aN:1aspect ratio, whereNis anint.What is the new behavior?
Bind to an integer value and have it converted to an Aspect Ratio correctly.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
Also, #4307