fix(dsl): manually align field mapping operations to allow aggregate functions execution in mappings. Fixes #960 #961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with aggregate functions by manually aligning field mapping operations, ensuring that the transformation functions execute correctly. Key changes include wrapping the transformation function calls with context.alignedOn in various mapping methods, modifying the AbstractField, ArrayBasedField, SequenceBasedField, and ConstantField classes accordingly.
collektive-dsl/src/commonMain/kotlin/it/unibo/collektive/aggregate/Field.kt
Outdated
Show resolved
Hide resolved
|
@nicolasfara if you approve, enable auto-merge. I disabled it for now. See #960. |
a5a0cd5 to
6f2d19b
Compare
nicolasfara
approved these changes
May 4, 2025
8f7e1e3 to
2aaae7b
Compare
…functions execution in mappings. Fixes #960
…gate/Field.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2aaae7b to
0065178
Compare
<
7A4F
a rel="nofollow" class="btn btn-primary" data-hydro-click="{"event_type":"authentication.click","payload":{"location_in_page":"signed out comment","repository_id":575470747,"auth_type":"SIGN_UP","originating_url":"https://github.com/Collektive/collektive/pull/961","user_id":null}}" data-hydro-click-hmac="566ecae2a550164adf4ce57f1c589afe8a90fb507e19f7082888c863195c71e1" href="/join?source=comment-repo">Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #960