[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(pinia-orm): Bring more consistence into saving functions #790

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(pinia-orm): Bring more consistence into saving functions #790

wants to merge 1 commit into from

Conversation

CodeDredd
Copy link
Owner
@CodeDredd CodeDredd commented Jan 3, 2023 •
edited
Loading

🔗 Linked issue

related to #774

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This refactoring brings more consistency to the insert, save & update functions. It also adds the missing update
function on repository level.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@CodeDredd CodeDredd changed the base branch from master to next-release January 10, 2023 17:00
@mllull
Copy link
mllull commented Jan 12, 2023

First of all, congratulations! This library is awesome 🎉 Thanks for you effort on improving it!

I'm glad to see that now I could use insert method and keep relationships saved! Today I had to change all my SomeLib.fresh(data) calls with this combination of code to keep relations and not break my code:

SomeLib.flush();
SomeLib.save(data);

I understand that with this PR now the fresh function will preserve models relationships, is it?

I see this PR very usefull, many thanks! 👍

@CodeDredd
Copy link
Owner Author
CodeDredd commented Jan 22, 2023 •
edited
Loading

@mllull nice to hear that...but as you noticed i havn't merged it for 1.5.0 because it's a breaking change for insert. So this PR will be the start for v2.0.0 i guess. ^^

understand that with this PR now the fresh function will preserve models relationships, is it?

Yes.

@CodeDredd CodeDredd added enhancement New feature or request breaking-changes Introducing new BREAKING CHANGES labels Jan 22, 2023
@CodeDredd CodeDredd added this to the 2.0.0 milestone Jan 22, 2023
Base automatically changed from next-release to master January 24, 2023 11:19
@CodeDredd CodeDredd mentioned this pull request Mar 13, 2023
Closed
3 tasks
@CodeDredd CodeDredd removed the breaking-changes Introducing new BREAKING CHANGES label Sep 20, 2023
@CodeDredd CodeDredd removed this from the 2.0.0 milestone Sep 20, 2023
@CodeDredd CodeDredd mentioned this pull request Sep 20, 2023
Closed
@CodeDredd CodeDredd added the breaking-changes Introducing new BREAKING CHANGES label Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking-changes Introducing new BREAKING CHANGES enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CodeDredd @mllull