8000 Fix "HTTP 400 Bad request" when DSN doesn't have URL and have individual components instead by traceon · Pull Request #306 · ClickHouse/clickhouse-odbc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix "HTTP 400 Bad request" when DSN doesn't have URL and have individual components instead #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2020
Merged

Fix "HTTP 400 Bad request" when DSN doesn't have URL and have individual components instead #306

merged 1 commit into from
Jul 22, 2020

Conversation

traceon
Copy link
Contributor
@traceon traceon commented Jul 12, 2020

Use all possible overrides when building URI
Use host name when building HTTP [redirected] request

@traceon
Use all possible overrides when building URI
c8de2ca 
Use host name when building HTTP [redirected] request
@traceon traceon requested a review from Enmk July 12, 2020 19:55
Enmk
Enmk approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor
@Enmk Enmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Ok

@Enmk Enmk merged commit fcc4572 into ClickHouse:master Jul 22, 2020
@traceon traceon deleted the url-construction-fix branch August 20, 2020 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enmk Enmk Enmk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@traceon @Enmk
0