Integrate preprocess scripts #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…), and cleans up working_dir config property
Signed-off-by: Brianna Major <brianna.major@taloid.khq.kitware.com>
Signed-off-by: Brianna Major <brianna.major@taloid.khq.kitware.com>
993943a to
d2af8df
Compare
The functions that calculate these values should perform the checks and return all ones. This simplifies the higher-level math to allow us to take the product anyways, regardless of the thickness. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Do not require physics package
For cylindrical detectors, we need to take into account the radius for calibration flags and parameters. This uses the old, non-lmfit style for defining calibration flags and parameters. We will be able to eliminate all of this when we upgrade the HEDM calibration to use the new lmfit calibration style... But for now, we need to maintain this. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
simple fixes
The expression indicates that the parameter is computed, and thus should not be allowed to vary. This prevents an issue where, if the Y value of 'IMAGE-PLATE-4' for TARDIS was allowed to vary using the old parameter flags, and TARDIS engineering constraints are used such that the Y value of 'IMAGE-PLATE-4' is computed, that we won't accidentally set that parameter to vary. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Due to a bug where we were accidentally setting IP4-Y to vary, even though it is supposed to be computed, we were actually not applying engineering constraints in this test. Since we weren't actually applying engineering constraints in the testing before, just disable them for now. We can look into adding them later. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Take into account radius for calibration params
…t-templates Add instrument templates for dynamic compression
d2af8df to
985a03d
Compare
834ad77 to
57be82f
Compare
ci: update actions/upload-artifact to v4
Using a list of tuples forces the dumper to add type annotations, while using a list of list avoid this issue.
Eiger should accept only one file provided via absolute_path while Dexelas series of files constructed using command line arguments
The latter is not a subset of the former. A new class is introduced Chess_Arguments that is a superset of both
Missing types found using mypy hexrd/preprocess/ --follow-imports=skip --disallow-untyped-defs mypy hexrd/cli/preprocess.py --follow-imports=skip --disallow-untyped-defs using mypy --version mypy 1.14.1 (compiled: yes)
Arguments set to None in argument profiles will be treated as required positional arguments. This behavior matches the original scripts.
57be82f to
274e1f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.