8000 fix(css markdown): *[id] is covered by header by jalenzz · Pull Request #45 · ChrAlpha/hexo-theme-cards · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(css markdown): *[id] is covered by header #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 24, 2020
Merged

fix(css markdown): *[id] is covered by header #45

merged 2 commits into from
Aug 24, 2020

Conversation

jalenzz
Copy link
Contributor
@jalenzz jalenzz commented Aug 24, 2020 •
edited
Loading

TOC 脚注 之类的在跳转时会被 header 遮挡

@ChrAlpha
Copy link
Owner
ChrAlpha commented Aug 24, 2020 •
edited
Loading

两点：

  1. 54px 只是我在博客中修改过的数据，默认的 header 宽度为 60px，使用 $header_height 调用会更规范。
  2. 并非所有人都会开启 header sticky 功能，应该单独判断一次

@ChrAlpha ChrAlpha changed the title 🐛 *[id] is covered by header fix(css markdown): *[id] is covered by header Aug 24, 2020
@ChrAlpha ChrAlpha merged commit 82c80a1 into ChrAlpha:master Aug 24, 2020
@ChrAlpha
Copy link
Owner

Anyway, nice PR!

ChrAlpha added a commit that referenced this pull request Aug 24, 2020
@ChrAlpha
Revert "fix(css markdown): *[id] is covered by header (#45)"
a23ed20 
This reverts commit 82c80a1.
@jalenzz
Copy link
Contributor Author
jalenzz commented Aug 24, 2020

抱歉没认真看，不过第二点我觉得没开启 header sticky，在跳转时保持上方的一定距离也还是挺不错的😛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jalenzz @ChrAlpha
0