remove swift-algorithms package in favor of manully importing needed … #5069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 8, 2023
|
@pmairoldi, just asking, it seems builds fine, are you having problems still and have to remove the packages? |
|
Don't think so. I removed everything. |
|
what don't compile? |
|
Nothing but it's more to fix the Bitcode and build for distribution errors. We use only 2 functions. I'd rather own the code than have a dependency for such a small thing. |
This was referenced Sep 6, 2023
hectormatos2011
pushed a commit
to mudflapapp/Charts
that referenced
this pull request
Apr 10, 2025
…lgorithms remove swift-algorithms package in favor of manully importing needed …
hectormatos2011
pushed a commit
to mudflapapp/Charts
that referenced
this pull request
Apr 10, 2025
…lgorithms remove swift-algorithms package in favor of manully importing needed …
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the need for swift-algorithms.
We were using only 2 functions so I duplicated the source code into our codebase. We now own this and do not have dependencies.
Addresses #4919 & #4938