10000 Update ChartDataSet.swift by batikansosun · Pull Request #4861 · ChartsOrg/Charts · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update ChartDataSet.swift #4861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2022
Merged

Update ChartDataSet.swift #4861

merged 1 commit into from
Aug 28, 2022

Conversation

batikansosun
Copy link
Contributor

Missing method.

Xcode 14 Beta 3 issues.
Unavailable instance method 'replaceSubrange(_:with:)' was used to satisfy a requirement of protocol 'RangeReplaceableCollection'

Issue

Xcode 14 Beta 3 issues.
Unavailable instance method 'replaceSubrange(_:with:)' was used to satisfy a requirement of protocol 'RangeReplaceableCollection'

Goals ⚽

Instance method 'replaceSubrange(_:with:)' need to adding.

Implementation Details 🚧

Added unavailable instance method 'replaceSubrange(_:with:)'.

Testing Details 🔍

@batikansosun
Update ChartDataSet.swift
9e4c77c 
Missing method.
@dingtianran
Copy link

Nice work
🤞

@magneroald
Copy link
magneroald commented Jul 21, 2022 •
edited
Loading

Thanks for the fix.
I also get this compilation error on xcode 14 beta 3:
Referencing instance method 'makeIterator()' on 'Collection' requires the types 'IndexingIterator<ChartData>' and 'IndexingIterator<RadarChartData>' be equivalent

Any solution to this?

The solution was actually described in "Fixes for Swift 5.7 compiler" topic:

add "as ChartData" to the lines that gives the error:

candleData as ChartData
radarData as ChartData

@pmairoldi pmairoldi self-assigned this Aug 27, 2022
@pmairoldi pmairoldi merged commit 130b505 into ChartsOrg:master Aug 28, 2022
@pmairoldi
Copy link
Collaborator

Thanks for the contribution!

This was referenced Aug 28, 2022
Closed
Closed
mikehouse added a commit to mikehouse/Charts that referenced this pull request Sep 8, 2022
@mikehouse
Fix Xcode 14 compilation
7f9d3c8 
ChartsOrg#4861
@jaytrisw jaytrisw mentioned this pull request Sep 8, 2022
Closed
1 task
@grangej
Copy link
grangej commented Sep 11, 2022

Can we please have this one fix back ported to 3.x ?

hboon added a commit to AlphaWallet/Charts that referenced this pull request Sep 12, 2022
@hboon
Patch v3.6.0 with ChartsOrg#4861 so it works with Xcode 14 RC
85ec4d0
@pmairoldi
Copy link
Collaborator

We will not patch older versions of the library for newer Xcode versions. Your best bet is to update or fork the library.

@nikitap1298 nikitap1298 mentioned this pull request Sep 12, 2022
Closed
@linxiangyang112
Copy link

Can you change the minimum version to 10.0

@pmairoldi
Copy link
Collaborator

I believe there is a technical reason behind it so we cannot. Is there a reason you still need to support such an old iOS version? The market share seems to indicate very low to 0 usage of this version https://developer.apple.com/support/app-store/

pandaiios9 added a commit to pandaiios9/Charts that referenced this pull request Sep 14, 2022
@pandaiios9
Update ChartDataSet.swift
448675d 
refer from ChartsOrg#4861
pandaiios9 added a commit to pandaiios9/Charts that referenced this pull request Sep 14, 2022
@pandaiios9
Update ChartDataSet.swift
02fff8e 
refer on ChartsOrg#4861
@EarthHeroOrg
Copy link

@linxiangyang112 we use 10.3 and found a fix in the conversation here:

#4903

@gaoDean gaoDean mentioned this pull request Jan 19, 2023
Open
gaoDean added a commit to gaoDean/zmk-ble that referenced this pull request Jan 19, 2023
@gaoDean
fix(deps): update Charts dep (see ChartsOrg/Charts#4861)
d3f801e
gaoDean added a commit to gaoDean/zmk-ble that referenced this pull request Jan 19, 2023
@gaoDean
fix(deps): update Charts for xcode14 (ChartsOrg/Charts#4861)
478cc45
@simson2010
Copy link

Hi, did anyone know about this change, I believe that this code works before without this update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pmairoldi pmairoldi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@batikansosun @dingtianran @magneroald @pmairoldi @grangej @linxiangyang112 @EarthHeroOrg @simson2010
0