8000 Revert https://github.com/danielgindi/Charts/pull/4271 and disable parent scroll view on dragging by remlostime · Pull Request #4700 · ChartsOrg/Charts · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Revert https://github.com/danielgindi/Charts/pull/4271 and disable parent scroll view on dragging #4700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 31, 2021
Merged

Revert https://github.com/danielgindi/Charts/pull/4271 and disable parent scroll view on dragging #4700

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions Source/Charts/Charts/BarLineChartViewBase.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -739,6 +739,10 @@ open class BarLineChartViewBase: ChartViewBase, BarLineScatterCandleBubbleChartD
// We will only handle highlights on NSUIGestureRecognizerState.Changed

_isDragging = false

// Prevent the parent scroll view from scrolling
_outerScrollView?.nsuiIsScrollEnabled = false

}
}
else if recognizer.state == NSUIGestureRecognizerState.changed
Expand Down Expand Up @@ -790,15 +794,15 @@ open class BarLineChartViewBase: ChartViewBase, BarLineScatterCandleBubbleChartD
}

_isDragging = false

delegate?.chartViewDidEndPanning?(self)
}

if _outerScrollView !== nil
{
_outerScrollView?.nsuiIsScrollEnabled = true
_outerScrollView = nil
}

delegate?.chartViewDidEndPanning?(self)
}
}

Expand Down
0