8000 Fixed lambdaf issue by carlrodriguez · Pull Request #311 · COSMIC-PopSynth/COSMIC · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixed lambdaf issue #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 1, 2019
Merged

Conversation

carlrodriguez
Copy link
Contributor

Reverted COSMIC to use lambdaf=0.5 instead of 1.0 and changed the defaults as well. This fixes the NaNs we were seeing in some binary evolution

@coveralls
Copy link
coveralls commented Oct 1, 2019

Pull Request Test Coverage Report for Build 827

  • 3 of 8 (37.5%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.007%) to 45.077%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cosmic/src/comenv.f 1 2 50.0%
cosmic/src/zfuncs.f 0 1 0.0%
cosmic/src/hrdiag.f 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
cosmic/src/zfuncs.f 1 62.53%
Totals Coverage Status
Change from base Build 825: 0.007%
Covered Lines: 6963
Relevant Lines: 15447

💛 - Coveralls

@codecov-io
Copy link
codecov-io commented Oct 1, 2019

Codecov Report

Merging #311 into develop will increase coverage by 0.02%.
The diff coverage is 60%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #311      +/-   ##
===========================================
+ Coverage    53.23%   53.25%   +0.02%     
===========================================
  Files           35       35              
  Lines         7071     7063       -8     
===========================================
- Hits          3764     3761       -3     
+ Misses        3307     3302       -5
Impacted Files Coverage Δ
cosmic/utils.py 81.4% <ø> (+0.08%) ⬆️
cosmic/src/zfuncs.f 62.53% <0%> (-0.16%) ⬇️
cosmic/src/benchmarkevolv2.f 100% <100%> (ø) ⬆️
cosmic/src/comenv.f 18.85% <50%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20624da...c6ae476. Read the comment docs.

Carl added 4 commits October 1, 2019 16:07
Merge remote-tracking branch 'upstream/develop' into develop
Merge remote-tracking branch 'upstream/develop' into develop
@katiebreivik
Copy link
Collaborator

Looks good. Thanks @carlrodriguez 🥇

@katiebreivik katiebreivik merged commit 0a21761 into COSMIC-PopSynth:develop Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0