fixed error in call to comenv due to secondary #589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #589 +/- ##
========================================
Coverage 86.91% 86.91%
========================================
Files 40 40
Lines 25440 25440
========================================
Hits 22111 22111
Misses 3329 3329
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Common envelope calculations when initiated by the secondary were buggy; j1 and j2 were used incorrectly at two places.
To fix this, I have swapped j1 and j2, formation (j1) and formation(j2) in call to the comenv in evolv2.f when common envelope is initiated by the secondary in a contact system.
Similarly, id for first star in CE (star responsible for CE) was always assumed to be 1 when calling hrdiag through comenv.f. This is again incorrect in the above case.
I have modified the call the hrdiag to use star1 and star 2 instead.