8000 Remove assumption that platform metadata contains IDNumber property. by selimnairb · Pull Request #70 · CCOMJHC/WIBL · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove assumption that platform metadata contains IDNumber property. #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2025
Merged

Remove assumption that platform metadata contains IDNumber property. #70

merged 1 commit into from
May 8, 2025

Conversation

selimnairb
Copy link
Member

Addresses #69

Confirmed that the affected change is the only place where 'IDNumber' is explicitly referenced in the wibl-python code.

@selimnairb selimnairb requested a review from brian-r-calder May 8, 2025 13:36
brian-r-calder
brian-r-calder approved these changes May 8, 2025
View reviewed changes
Copy link
Collaborator
@brian-r-calder brian-r-calder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, although we should eventually track down why something named "logger" in the info is using the IDNumber (i.e., the MMSI or IMO number of the boat); it feels like this might be something that's better being the logger's UUID.

@selimnairb selimnairb merged commit d569584 into main May 8, 2025
@selimnairb selimnairb mentioned this pull request May 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-r-calder brian-r-calder brian-r-calder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@selimnairb @brian-r-calder
0