8000 Add config for ansible-lint-action by jagsgill · Pull Request #3 · CAAPIM/gateway-ansible-playbook · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add config for ansible-lint-action #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2020
Merged

Conversation

jagsgill
Copy link
Collaborator

This PR will add config for the free Github Action provided by official Ansible team called ansible-lint-action.

Currently we instructed contributors to setup the linter locally, but usage cannot be enforced. Using this action will enforce the quality check on PRs before merging.

@jagsgill jagsgill self-assigned this Apr 15, 2020
@jagsgill jagsgill changed the base branch from master to develop April 15, 2020 22:41
@jagsgill
Copy link
Collaborator Author

Need to merge #5 before this one

@jchanbcbc
Copy link
Contributor

Let me know when the other merge happens so I can verify the checks passing. It is interesting it flags everything and not just the lines changed on commit. Thanks.

@jagsgill jagsgill force-pushed the ansible-lint-action branch from 34bfea7 to 157e327 Compare April 17, 2020 16:58
Copy link
Contributor
@jchanbcbc jchanbcbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jagsgill
Copy link
Collaborator Author

I rebased on the cleanup and it's passing. It is not ideal that does not examine just the patch changes without modification but now that existing issues are cleaned up this should be good to go.

@jagsgill jagsgill merged commit 481c8d1 into develop Apr 17, 2020
@jagsgill jagsgill deleted the ansible-lint-action branch April 17, 2020 17:04
jagsgill pushed a commit that referenced this pull request Apr 20, 2020
* US639049 playbook to update expired Gateway OS user passwords
alisterz added a commit that referenced this pull request May 12, 2020
* Add config for ansible-lint-action (#3)

* TA1415063 Consolidate policy manager user (#6)

* Ta1415061 consolidate group vars (#8)

* Add role for updating hostnames used by OTK (#10)

* TA1416569 skip DB schema upgrade if DB is upgraded already (#12)

* refactoring the hosts file and other enhancements (#4)

* Use template file for autoprovision roles (#16)

* Add tutorial doc for 3-node in-place upgrade. (#17)

* Parameterize no log flag (#18)

* Add descriptions for group vars (#19)

* Add descriptions for playbooks (#20)

* Add extensibility guide (#21)

* Add back papim vars (#24)

* Rename autoprovision roles (#23)

* update readme (#22)

* Update sample playbook (#25)

* Fix replication role (#26)

* Fix the gateway_controller_cleanup/tasks/main.yml to include the vars… (#27)

* Change analyzer report location (#29)

* update documentation (#28)

* fix issue with custom attributes (#32)

* Fix stop_gateway.yml  (#31)

* Update the README.md with the supported scenarios the playbooks cover. (#33)

* Collect small corrections (#34)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0