8000 Add support for HOCON file type by godlixe · Pull Request #103 · Boeing/config-file-validator · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add support for HOCON file type #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 11, 2023
Merged

Add support for HOCON file type #103

merged 2 commits into from
Dec 11, 2023

Conversation

godlixe
Copy link
Contributor
@godlixe godlixe commented Dec 5, 2023

Changes in this PR :

  • Add validator for HOCON file types
  • Test cases for HOCON file type validation

Somehing to keep in mind, HOCON has multiple file extensions, .properties, .json, and .conf as defined in Lightbend's HOCON documentation and Sponge's HOCON guide. But there are also people using the extension .hocon. I decided to only validate files with .hocon extension to avoid conflicts with other files that may have the same extension but different configuration language (.properties, .json, and .conf).

Closes #64

kehoecj
kehoecj requested changes Dec 5, 2023
View reviewed changes
@godlixe godlixe requested a review from kehoecj December 5, 2023 16:07
jd4235
jd4235 approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor
@jd4235 jd4235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kehoecj
kehoecj approved these changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator
@kehoecj kehoecj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good implementation just focusing on .hocon file extensions for now until we can support targeting different file types.

@kehoecj kehoecj merged commit 7abc395 into Boeing:main Dec 11, 2023
@kehoecj kehoecj added this to the v1.6.0 milestone Dec 18, 2023
@kehoecj kehoecj added the OSS Community Contribution Contributions from the OSS Community label Dec 18, 2023
shiina4119 pushed a commit to shiina4119/config-file-validator that referenced this pull request Aug 23, 2024
@godlixe @shiina4119
Add support for HOCON file type (Boeing#103)
8ef2fd5 
* Add support for HOCON file type

* Alphabetize file type
shiina4119 pushed a commit to shiina4119/config-file-validator that referenced this pull request Oct 4, 2024
@godlixe @shiina4119
Add support for HOCON file type (Boeing#103)
bc70a4b 
* Add support for HOCON file type

* Alphabetize file type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jd4235 jd4235 jd4235 approved these changes

@kehoecj kehoecj kehoecj approved these changes

@jackswiney jackswiney jackswiney approved these changes

Assignees
No one assigned
Labels
OSS Community Contribution Contributions from the OSS Community
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.

Add support for HOCON config files
4 participants
@godlixe @jd4235 @kehoecj @jackswiney
0