8000 Improve FileCache directory creation by uuf6429 · Pull Request #373 · Behat/Gherkin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improve FileCache directory creation #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Improve FileCache directory creation #373

wants to merge 4 commits into from

Conversation

uuf6429
Copy link
Contributor
@uuf6429 uuf6429 commented Jun 12, 2025 •
edited
Loading
  • makes the mkdir() call more atomic
  • ensures that the specified path is definitely a directory

@codecov Codecov
Copy link
codecov bot commented Jun 12, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.27%. Comparing base (b4870b1) to head (4cd633b).

Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #373      +/-   ##
============================================
+ Coverage     96.23%   96.27%   +0.03%     
- Complexity      654      658       +4     
============================================
  Files            43       43              
  Lines          1940     1958      +18     
============================================
+ Hits           1867     1885      +18     
  Misses           73       73
Flag Coverage Δ
php8.1 96.27% <100.00%> (+0.03%) ⬆️
php8.1--with=symfony/yaml:^5.4 96.27% <100.00%> (+0.03%) ⬆️
php8.1--with=symfony/yaml:^6.4 96.27% <100.00%> (+0.03%) ⬆️
php8.2 96.27% <100.00%> (+0.03%) ⬆️
php8.3 96.27% <100.00%> (+0.03%) ⬆️
php8.4 96.27% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

uuf6429
uuf6429 commented Jun 14, 2025
View reviewed changes
@uuf6429 uuf6429 marked this pull request as ready for review June 14, 2025 17:53
@uuf6429 uuf6429 force-pushed the chore/improve-filecache-dir-creation branch from b3056be to 50eea5f Compare June 14, 2025 17:54
acoulton
acoulton reviewed Jun 15, 2025
View reviewed changes
Copy link
Contributor
@acoulton acoulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @uuf6429

@uuf6429 uuf6429 requested a review from acoulton June 15, 2025 20:24
acoulton
acoulton approved these changes Jun 19, 2025
View reviewed changes
Copy link
Contributor
@acoulton acoulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @uuf6429

@uuf6429 uuf6429 mentioned this pull request Jun 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acoulton acoulton acoulton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uuf6429 @acoulton
0