8000 Complete BlockHeader consensus encoding by dr-orlovsky · Pull Request #82 · BP-WG/bp-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Complete BlockHeader consensus encoding #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2024
Merged

Complete BlockHeader consensus encoding #82

merged 1 commit into from
Mar 18, 2024

Conversation

dr-orlovsky
Copy link
Member
@dr-orlovsky dr-orlovsky commented Mar 17, 2024 •
edited
Loading

Required for electrum client - see BP-WG/bp-electrum-client@41fb0d6

@dr-orlovsky dr-orlovsky added *consensus* Issues affecting distributed concensus test Test implementation or failures labels Mar 17, 2024
@dr-orlovsky dr-orlovsky added this to the v0.11.0 milestone Mar 17, 2024
@dr-orlovsky dr-orlovsky requested a review from nicbus March 17, 2024 10:28
@codecov Codecov
Copy link
codecov bot commented Mar 17, 2024

Codecov Report

Attention: Patch coverage is 98.57143% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 48.3%. Comparing base (78b23e3) to head (26ec879).

Files Patch % Lines
consensus/src/block.rs 96.7% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##           master     #82     +/-   ##
========================================
+ Coverage    47.2%   48.3%   +1.1%     
========================================
  Files          36      36             
  Lines        3216    3284     +68     
========================================
+ Hits         1518    1587     +69     
+ Misses       1698    1697      -1
Flag Coverage Δ
rust 48.3% <98.6%> (+1.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dr-orlovsky dr-orlovsky self-assigned this Mar 18, 2024
@nicbus nicbus mentioned this pull request Mar 18, 2024
Merged
nicbus
nicbus approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member
@nicbus nicbus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 26ec879

@dr-orlovsky dr-orlovsky merged commit f593b47 into master Mar 18, 2024
@dr-orlovsky dr-orlovsky deleted the block_header branch September 4, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicbus nicbus nicbus approved these changes

Assignees

@dr-orlovsky dr-orlovsky

Labels
*consensus* Issues affecting distributed concensus test Test implementation or failures
Projects
No open projects
Core protocol
Status: Done
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dr-orlovsky @nicbus
0