8000 Test WASM builds by dr-orlovsky · Pull Request #72 · BP-WG/bp-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Test WASM builds #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 20, 2024
Merged

Test WASM builds #72

merged 2 commits into from
Jan 20, 2024

Conversation

dr-orlovsky
Copy link
Member

Closes #66

@dr-orlovsky dr-orlovsky added the ci Contininous integration-relased issue label Jan 19, 2024
@dr-orlovsky dr-orlovsky added this to the v0.11.0 milestone Jan 19, 2024
@dr-orlovsky dr-orlovsky requested a review from crisdut January 19, 2024 12:17
@dr-orlovsky dr-orlovsky mentioned this pull request Jan 19, 2024
Closed
@codecov Codecov
Copy link
codecov bot commented Jan 19, 2024 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (04e277b) 48.0% compared to head (02b26ae) 48.0%.

Files Patch % Lines
seals/src/txout/blind.rs 0.0% 1 Missing ⚠️
seals/src/txout/explicit.rs 0.0% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##           master     #72     +/-   ##
========================================
- Coverage    48.0%   48.0%   -0.0%     
========================================
  Files          36      36             
  Lines        3141    3143      +2     
========================================
  Hits         1509    1509             
- Misses       1632    1634      +2
Flag Coverage Δ
rust 48.0% <0.0%> (-<0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cryptoquick
cryptoquick previously approved these changes Jan 20, 2024
View reviewed changes
Copy link
Member
@cryptoquick cryptoquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Good thinking adding the test.

@dr-orlovsky dr-orlovsky merged commit cbcaf16 into master Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cryptoquick cryptoquick cryptoquick left review comments

@crisdut crisdut Awaiting requested review from crisdut

Assignees
No one assigned
Labels
ci Contininous integration-relased issue
Projects
Client-side-validation
Status: Done
Core protocol
Status: Done
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.

build: target wasm32-unknown-unknown failed on 0.11.0-beta.1
2 participants
@dr-orlovsky @cryptoquick
0