Use registry pattern for ClassificationMetricSet #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #40 +/- ##
=======================================
Coverage 99.77% 99.77%
=======================================
Files 16 16
Lines 884 886 +2
=======================================
+ Hits 882 884 +2
Misses 2 2
Continue to review full report at Codecov.
|
7974
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR upgrades the
rexmex.utils.Annotatorclass to implement the registry pattern, which basically means it keeps track of all of the functions it gets applied to. This is actually the same thing that theClassificationMetricSetclass does in its__init__, so it can be used to reduce the hard-coded aspects there.Previously existing tests should be sufficient to check that this still has the same functionality as before (with the added benefit of including all metrics instead of just a handful)
Changes
rexmex.utils.Annotatorrexmex.metricset.ClassificationMetricSetto use registry fromrexmex.metrics.classification.classifications