refactor(annotations): allow batch deletion of annotation configs #7236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
RogerHYang
approved these changes
Apr 22, 2025
| return DeleteAnnotationConfigPayload( | ||
| deleted_annotation_configs = result.all() | ||
| if len(deleted_annotation_configs) < len(config_ids): | ||
| await session.rollback() |
There was a problem hiding this comment.
it seems to me that rollback should be automatic when it's inside the context manager
There was a problem hiding this comment.
The explicit rollback seems to be necessary
src/phoenix/server/api/mutations/annotation_config_mutations.py
Outdated
Show resolved
Hide resolved
This was referenced Apr 24, 2025
mikeldking
pushed a commit
that referenced
this pull request
Apr 30, 2025
mikeldking
pushed a commit
that referenced
this pull request
May 2, 2025
mikeldking
pushed a commit
that referenced
this pull request
May 9, 2025
GeLi2001
pushed a commit
that referenced
this pull request
May 21, 2025
RogerHYang
pushed a commit
that referenced
this pull request
May 27, 2025
efontan-dialpad
pushed a commit
to gluru/phoenix
that referenced
this pull request
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow batch deletions of annotation configs from the GraphQL perspective.
resolves #7224