feat(annotations): span annotation filters #7109
Conversation
commit: |
| input SpanAnnotationFilterCondition { | ||
| name: String | ||
| source: AnnotationSource | ||
| userIds: [GlobalID!] |
There was a problem hiding this comment.
Curious what the use-case for a list of users would be here. In general I like it, mainly curious.
There was a problem hiding this comment.
If you want to filter for annotations from a particular user/ set of users. I think was your idea, it's on the ticket.
| user_rowids = set( | ||
|
|
||
| ) |
There was a problem hiding this comment.
nit. this can be cached in a private variable via __post_init__ on the Filter object itself. FWIW, a list would be faster if the set is small.
There was a problem hiding this comment.
Probably true wrt list.
| include: Optional[SpanAnnotationFilterCondition] = UNSET | ||
| exclude: Optional[SpanAnnotationFilterCondition] = UNSET |
There was a problem hiding this comment.
nit. maybe raise an exception via __post_init__ if there is a contradiction, e.g. when a name is both included and excluded
There was a problem hiding this comment.
That strikes me as a situation we should just return an empty list.
resolves #6921