feat(annotations): Annotation Config UI #6856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cephalization
commented
Mar 20, 2025
|
Since we have room, can we align these checkboxes horizontally? |
|
This area of labels needs a label and possibly some explaining text. |
mikeldking
reviewed
Mar 24, 2025
| bodyStyle={{ padding: 0 }} | ||
| extra={ | ||
| <DialogTrigger> | ||
| <Button size="S">New Annotation Config</Button> |
There was a problem hiding this comment.
Maybe a + icon with the word "New Configuration" - just to keep things more proper.
| @@ -8,7 +8,7 @@ import { formatFloat } from "@phoenix/utils/numberFormatUtils"; | |||
| import { AnnotationColorSwatch } from "./AnnotationColorSwatch"; | |||
| import { Annotation } from "./types"; | |||
|
|
|||
| type AnnotationDisplayPreference = "label" | "score"; | |||
| type AnnotationDisplayPreference = "label" | "score" | "none"; | |||
There was a problem hiding this comment.
probably needs a docstring
| AnnotationConfigFreeform, | ||
| AnnotationConfigOptimizationDirection, | ||
| AnnotationConfigType, | ||
| } from "@phoenix/pages/settings/types"; |
There was a problem hiding this comment.
Suggested change
| } from "@phoenix/pages/settings/types"; | |
| } from "./types"; |
just to promote some level of directory encapsulation
| data-testid="optimization-direction-picker" | ||
| direction="column" | ||
| > | ||
| <Label>Optimization Direction</Label> |
There was a problem hiding this comment.
we are gonna need descriptions of these - they are not self evident
| render={({ field, fieldState: { error } }) => ( | ||
| <TextField {...field} isInvalid={!!error}> | ||
| <Label>Annotation Name</Label> | ||
| <Input placeholder="correctness" /> |
There was a problem hiding this comment.
With placeholders, it's best practice to not put a valid value there since it looks valid. Always use some sort of text like "e.x. correctness"
Comment on lines
262
to
284
| <> | ||
| <Controller | ||
| control={control} | ||
| name="lowerBound" | ||
| rules={{ | ||
| required: "Min is required", | ||
| }} | ||
| render={({ | ||
| field: { value, ...field }, | ||
| fieldState: { error }, | ||
| }) => ( | ||
| <NumberField | ||
| {...field} | ||
| value={typeof value === "number" ? value : undefined} | ||
| isInvalid={!!error} | ||
| > | ||
| <Label>Min</Label> | ||
| <Input placeholder="0" /> | ||
| <FieldError>{error?.message}</FieldError> | ||
| </NumberField> | ||
| )} | ||
| /> | ||
| <Controller |
There was a problem hiding this comment.
can you put the min and max on a single line and somehow describe that it's a range?
| aria-label={`Value ${index + 1}`} | ||
| isInvalid={!!error} | ||
| > | ||
| <Input placeholder="Category label" /> |
There was a problem hiding this comment.
Suggested change
| <Input placeholder="Category label" /> | |
| <Input placeholder="the annotation label" /> |
| return tokens; | ||
| } | ||
| case "CONTINUOUS": | ||
| return `Range: ${row.lowerBound} - ${row.upperBound}`; |
There was a problem hiding this comment.
Suggested change
| return `Range: ${row.lowerBound} - ${row.upperBound}`; | |
| return `${row.lowerBound} - ${row.upperBound}`; |
| @@ -55,6 +55,8 @@ const getAnnotationDisplayValue = ( | |||
| annotation.label || | |||
| "n/a" | |||
| ); | |||
| case "none": | |||
There was a problem hiding this comment.
Suggested change
| case "none": | |
| case "none": |
Can you make it so that you don't get an inconsistent padding?
annotation.config.post.cleanup.mov |
mikeldking
approved these changes
Mar 24, 2025
mikeldking
pushed a commit
that referenced
this pull request
Mar 25, 2025
* feat(annotations): Annotation Config UI * Fix style merging in AnnotationLabel * Handle large values * Rename card * Persist annotation config via gql * Convert annotation config popover to dialog * Implement annotation selection toolbar + deletion * Remove bad lint rule * Replace dialog extra buttons with cancel button * styling changes * clean up annotation label * Remove hover state from annotation label unless clickable
mikeldking
pushed a commit
that referenced
this pull request
Mar 28, 2025
* feat(annotations): Annotation Config UI * Fix style merging in AnnotationLabel * Handle large values * Rename card * Persist annotation config via gql * Convert annotation config popover to dialog * Implement annotation selection toolbar + deletion * Remove bad lint rule * Replace dialog extra buttons with cancel button * styling changes * clean up annotation label * Remove hover state from annotation label unless clickable
axiomofjoy
pushed a commit
that referenced
this pull request
Mar 29, 2025
* feat(annotations): Annotation Config UI * Fix style merging in AnnotationLabel * Handle large values * Rename card * Persist annotation config via gql * Convert annotation config popover to dialog * Implement annotation selection toolbar + deletion * Remove bad lint rule * Replace dialog extra buttons with cancel button * styling changes * clean up annotation label * Remove hover state from annotation label unless clickable
mikeldking
pushed a commit
that referenced
this pull request
Apr 2, 2025
* feat(annotations): Annotation Config UI * Fix style merging in AnnotationLabel * Handle large values * Rename card * Persist annotation config via gql * Convert annotation config popover to dialog * Implement annotation selection toolbar + deletion * Remove bad lint rule * Replace dialog extra buttons with cancel button * styling changes * clean up annotation label * Remove hover state from annotation label unless clickable
mikeldking
pushed a commit
that referenced
this pull request
Apr 9, 2025
* feat(annotations): Annotation Config UI * Fix style merging in AnnotationLabel * Handle large values * Rename card * Persist annotation config via gql * Convert annotation config popover to dialog * Implement annotation selection toolbar + deletion * Remove bad lint rule * Replace dialog extra buttons with cancel button * styling changes * clean up annotation label * Remove hover state from annotation label unless clickable
This was referenced Apr 11, 2025
mikeldking
pushed a commit
that referenced
this pull request
Apr 21, 2025
* feat(annotations): Annotation Config UI * Fix style merging in AnnotationLabel * Handle large values * Rename card * Persist annotation config via gql * Convert annotation config popover to dialog * Implement annotation selection toolbar + deletion * Remove bad lint rule * Replace dialog extra buttons with cancel button * styling changes * clean up annotation label * Remove hover state from annotation label unless clickable
This was referenced Apr 24, 2025
mikeldking
pushed a commit
that referenced
this pull request
Apr 30, 2025
* feat(annotations): Annotation Config UI * Fix style merging in AnnotationLabel * Handle large values * Rename card * Persist annotation config via gql * Convert annotation config popover to dialog * Implement annotation selection toolbar + deletion * Remove bad lint rule * Replace dialog extra buttons with cancel button * styling changes * clean up annotation label * Remove hover state from annotation label unless clickable
mikeldking
pushed a commit
that referenced
this pull request
May 2, 2025
* feat(annotations): Annotation Config UI * Fix style merging in AnnotationLabel * Handle large values * Rename card * Persist annotation config via gql * Convert annotation config popover to dialog * Implement annotation selection toolbar + deletion * Remove bad lint rule * Replace dialog extra buttons with cancel button * styling changes * clean up annotation label * Remove hover state from annotation label unless clickable
mikeldking
pushed a commit
that referenced
this pull request
May 9, 2025
* feat(annotations): Annotation Config UI * Fix style merging in AnnotationLabel * Handle large values * Rename card * Persist annotation config via gql * Convert annotation config popover to dialog * Implement annotation selection toolbar + deletion * Remove bad lint rule * Replace dialog extra buttons with cancel button * styling changes * clean up annotation label * Remove hover state from annotation label unless clickable
GeLi2001
pushed a commit
that referenced
this pull request
May 21, 2025
* feat(annotations): Annotation Config UI * Fix style merging in AnnotationLabel * Handle large values * Rename card * Persist annotation config via gql * Convert annotation config popover to dialog * Implement annotation selection toolbar + deletion * Remove bad lint rule * Replace dialog extra buttons with cancel button * styling changes * clean up annotation label * Remove hover state from annotation label unless clickable
RogerHYang
pushed a commit
that referenced
this pull request
May 27, 2025
* feat(annotations): Annotation Config UI * Fix style merging in AnnotationLabel * Handle large values * Rename card * Persist annotation config via gql * Convert annotation config popover to dialog * Implement annotation selection toolbar + deletion * Remove bad lint rule * Replace dialog extra buttons with cancel button * styling changes * clean up annotation label * Remove hover state from annotation label unless clickable
efontan-dialpad
pushed a commit
to gluru/phoenix
that referenced
this pull request
May 28, 2025
* feat(annotations): Annotation Config UI * Fix style merging in AnnotationLabel * Handle large values * Rename card * Persist annotation config via gql * Convert annotation config popover to dialog * Implement annotation selection toolbar + deletion * Remove bad lint rule * Replace dialog extra buttons with cancel button * styling changes * clean up annotation label * Remove hover state from annotation label unless clickable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Annotation.Config.mov