Fixed the problem of illegal path when decompressing *.BNK files of HOTD4 (PS3 Japan), Rambo (Arcade), SEGA GoldGun (Arcade) #8
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Illegal path
In the Japanese PS3 version of House of the dead 4（DISC ID:NPJB00198）, SEGA used the path of the DDS texture file as the file name, which caused the bnk extract tool to have an illegal path when pathlib.mkdir
This situation also occurs in the arcade games Rambo and SEGA GoldGun, which are also developed using the SEGA NN engine.
Solution
I added some checking code before the mkdir so that if an illegal file name is detected, the script will treat the drive letter as a folder instead of omitting it, which may help others writing recompression scripts.