[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stability: 3 - Legacy: Use ES2015 class syntax and extends keyword in… #16

Merged
merged 1 commit into from
Dec 29, 2021

Conversation

itamar-owlytics
Copy link
Contributor

…stead.

@itamar-owlytics
Copy link
Contributor Author

https://nodejs.org/api/util.html#utilinheritsconstructor-superconstructor

Stability: 3 - Legacy: Use ES2015 class syntax and extends keyword instead.

Usage of util.inherits() is discouraged. Please use the ES6 class and extends keywords to get language level inheritance support. Also note that the two styles are semantically incompatible.

@AndreasMadsen
Copy link
Owner

I read through the nodejs/node#4179 issue, I think this is a fair fix. It will also remove a dependency. I don't know @kgryte's objections, but I will publish this as a major version change, as going from ES5 to ES6 is breaking.

@AndreasMadsen AndreasMadsen merged commit edb8750 into AndreasMadsen:master Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants