build: upgrade go directive in go.mod to 1.17
#423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enables support for module graph pruning and lazy module loading for projects that are at Go 1.17 or higher. Reference: https://go.dev/ref/mod#go-mod-file-go Reference: https://go.dev/ref/mod#graph-pruning Reference: https://go.dev/ref/mod#lazy-loading Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
gucio321
requested changes
Dec 21, 2021
| go 1.16 | ||
| go 1.17 |
There was a problem hiding this comment.
Why is it necessary? IMO it is better to keep support for older go versions as long as possible
There was a problem hiding this comment.
oh, I'm sorry I've just read pr description 😀
Comment on lines
5
to
+17
| require ( | ||
| github.com/AllenDang/go-findfont v0.0.0-20200702051237-9f180485aeb8 | ||
| github.com/AllenDang/imgui-go v1.12.1-0.20211220065947-c3e78789ac41 | ||
| github.com/faiface/mainthread v0.0.0-20171120011319-8b78f0a41ae3 | ||
| github.com/go-gl/gl v0.0.0-20211210172815-726fda9656d6 // indirect | ||
| github.com/go-gl/glfw/v3.3/glfw v0.0.0-20211213063430-748e38ca8aec | ||
| github.com/go-resty/resty/v2 v2.7.0 | ||
| github.com/kylelemons/godebug v1.1.0 // indirect | ||
| github.com/pkg/browser v0.0.0-20210911075715-681adbf594b8 | ||
| github.com/sahilm/fuzzy v0.1.0 | ||
| github.com/stretchr/testify v1.7.0 | ||
| golang.org/x/image v0.0.0-20210628002857-a66eb6448b8d | ||
| ) | ||
|
|
||
| require ( |
There was a problem hiding this comment.
why is there a second require directive 🤔
There was a problem hiding this comment.
same here, forgot to read pr description XD
Codecov Report
@@ Coverage Diff @@
## master #423 +/- ##
======================================
Coverage 2.94% 2.94%
======================================
Files 30 30
Lines 3092 3092
======================================
Hits 91 91
Misses 3001 3001 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the
godirective ingo.modfile by runninggo mod tidy -go=1.17to enable module graph pruning and lazy module loading.Note 1: This does not prevent users with earlier Go versions from successfully building packages from this module.
Note 2: The additional
requiredirective is used to record indirect dependencies for Go 1.17 or higher, see https://go.dev/ref/mod#go-mod-file-go.