8000 fix(authn): remove auth middleware for webauthn login api by Mmx233 · Pull Request #8407 · AlistGo/alist · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(authn): remove auth middleware for webauthn login api #8407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2025

Conversation

Mmx233
Copy link
Contributor
@Mmx233 Mmx233 commented Apr 19, 2025

API router of authn login should not contain auth middleware. Currently, the API will throw an error only when there is an invalid token during login; If the token is empty, the request will succeed and the request will be granted a Guest identity, regardless of whether the Guest is disabled or not.

This PR is prerequisite for AlistGo/alist-web#274

image

image

Image for test: mmx233/alist:frontend-20250420

To meet testing requirements, this image includes changes from both AlistGo/alist-web#274 and AlistGo/alist-web#273.

@Mmx233 Mmx233 changed the title fix: remove auth middleware for authn login fix: remove auth middleware for webauthn login api Apr 19, 2025
@Mmx233 Mmx233 changed the title fix: remove auth middleware for webauthn login api fix(authn): remove auth middleware for webauthn login api Apr 22, 2025
@xhofe xhofe merged commit e532ab3 into AlistGo:main Apr 27, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3D01
Development

Successfully merging this pull request may close these issues.

2 participants
0