[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yolo_cpp_dll_no_gpu.vcxproj build failure #8555

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

CristiFati
Copy link
@CristiFati CristiFati commented Jun 13, 2022

Source file was missing from project (there already is an issue: #8529).

The fact that noone else noticed makes me wonder:

  1. Is this project still used / maintained / supported ?

  2. Are any of the .vcxprojs still used / maintained / supported?

If the answer to the questions is "yes", would it make sense to make further improvements to them?

@stephanecharette
Copy link
Collaborator

No, I don't believe the vcxprojs are still used. I think most people on Windows use the new .ps1 build scripts, or vcpkg to build.

@mwetzko
Copy link
mwetzko commented Jul 5, 2022

No, I don't believe the vcxprojs are still used. I think most people on Windows use the new .ps1 build scripts, or vcpkg to build.

Not true. I'm using them.

@mwetzko
Copy link
mwetzko commented Jul 5, 2022

Source file was missing from project.

The fact that noone else noticed makes me wonder:

1. Is this project still used / maintained / supported ?

2. Are any of the _.vcxproj_s still used / maintained / supported?

If the answer to the questions is "yes", would it make sense to make further improvements to them?

I usually edit errors out locally without complaint. Maybe others do as well, because I came across some sites where people had the same issue pointing to the missing files you have added in this PR.

@CristiFati
Copy link
Author
CristiFati commented Jul 6, 2022

Thank you for the answers.

Considering the lately commit scarcity, the pile of issues and PRs, I tend to think this repository is dead or way downhill. Is this the case?

Also, the test env is quite poor. Many tests fail because of setup issues totally unrelated to the changes.

@CristiFati
Copy link
Author

When (if ever) this is going to be merged, please let me know to rebase first.

@cenit cenit merged commit ef8ad4a into AlexeyAB:master Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants