-
-
Notifications
You must be signed in to change notification settings - Fork 43
openssh: FIDO support #848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please roll up the dependencies for this into this PR with one commit per dependency (and close the respective PRs when you have done so).
In addition, please fold in the openssh config file change PR into this.
Also, would you mind rebasing this onto the 2025-05-repo-rebuild branch so we can get it in with the new infra?
Signed-off-by: Dhruvin Gandhi <contact@dhru.vin>
@ermo, thanks for the review(s). I have one question: hidapi can be used under one of three licenses. The first two, GPL-3.0-or-later, and BSD-3-Clause, are fine, but the third one isn't OSI approved. First two licenses should cover most use cases, but the third one (-orig) is most permissive. Should I provide the third license in -devel package, and use a LicenseRef? I couldn't find an existing package using LicenseRef this way though. See: https://github.com/libusb/hidapi/blob/master/LICENSE.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@d5ng4i My take is that the BSD license is the best fit for AerynOS's packages.
Also, please squash the config file typo commit into the openssh commit proper, then rebuild openssh. If the manifest does not record the change, that is a bug.
The change will still be visible, but this is the nicest way of doing it.
Signed-off-by: Dhruvin Gandhi <contact@dhru.vin>
Signed-off-by: Dhruvin Gandhi <contact@dhru.vin>
Signed-off-by: Dhruvin Gandhi <contact@dhru.vin>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This adds FIDO support to openssh, which includes adding:
I've also fixed typos in openssh's
sysusers.conf
, andtmpfiles.conf
.hidapi is declared to be licensed under
GPL-3.0-or-later OR BSD-3-Clause
(dropping non OSI approved license).