10000 openssh: FIDO support by d5ng4i · Pull Request #848 · AerynOS/recipes · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

openssh: FIDO support #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 25, 2025
Merged

Conversation

d5ng4i
Copy link
Contributor
@d5ng4i d5ng4i commented May 17, 2025

This adds FIDO support to openssh, which includes adding:

  • libfido2
    • libcbor
    • hidapi

I've also fixed typos in openssh's sysusers.conf, and tmpfiles.conf.

hidapi is declared to be licensed under GPL-3.0-or-later OR BSD-3-Clause (dropping non OSI approved license).

@d5ng4i d5ng4i requested a review from a team as a code owner May 17, 2025 12:59
Copy link
Contributor
@ermo ermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please roll up the dependencies for this into this PR with one commit per dependency (and close the respective PRs when you have done so).

In addition, please fold in the openssh config file change PR into this.

Also, would you mind rebasing this onto the 2025-05-repo-rebuild branch so we can get it in with the new infra?

Signed-off-by: Dhruvin Gandhi <contact@dhru.vin>
@d5ng4i d5ng4i force-pushed the openssh-9.3p1-8 branch from bd208cb to f7e83ed Compare May 25, 2025 11:46
@d5ng4i d5ng4i changed the base branch from main to 2025-05-repo-rebuild May 25, 2025 11:46
@d5ng4i
Copy link
< 8000 div class="d-none d-sm-flex"> Contributor Author
d5ng4i commented May 25, 2025

@ermo, thanks for the review(s).

I have one question:

hidapi can be used under one of three licenses.

The first two, GPL-3.0-or-later, and BSD-3-Clause, are fine, but the third one isn't OSI approved.

First two licenses should cover most use cases, but the third one (-orig) is most permissive.

Should I provide the third license in -devel package, and use a LicenseRef? I couldn't find an existing package using LicenseRef this way though.

See: https://github.com/libusb/hidapi/blob/master/LICENSE.txt

@d5ng4i d5ng4i requested a review from ermo May 25, 2025 13:12
@d5ng4i d5ng4i mentioned this pull request May 25, 2025
Copy link
Contributor
@ermo ermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@d5ng4i My take is that the BSD license is the best fit for AerynOS's packages.

Also, please squash the config file typo commit into the openssh commit proper, then rebuild openssh. If the manifest does not record the change, that is a bug.

The change will still be visible, but this is the nicest way of doing it.

d5ng4i added 3 commits May 25, 2025 22:13
Signed-off-by: Dhruvin Gandhi <contact@dhru.vin>
Signed-off-by: Dhruvin Gandhi <contact@dhru.vin>
Signed-off-by: Dhruvin Gandhi <contact@dhru.vin>
@d5ng4i d5ng4i force-pushed the openssh-9.3p1-8 branch from f7e83ed to 72db52d Compare May 25, 2025 16:45
@d5ng4i d5ng4i requested a review from ermo May 25, 2025 16:53
Copy link
Contributor
@ermo ermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ermo ermo merged commit 051b66c into AerynOS:2025-05-repo-rebuild May 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0