Use Swift 5.9 custom executor #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MainActomaton2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
MainActomatonby changing it frompublic final classtopackage protocol(thus this PR is a breaking change), and move previous implementation intopackage class MainActomaton1(ver 1), then adding a newMainActomaton2(ver 2).MainActomaton2is a full replacement ofMainActomaton1using Swift 5.9's Custom Executor, which is available from macOS 14.0 / iOS 17.0.In Swift 5.9,
MainActomaton2is now capable of inheritingactor Actomaton's existing code without code duplication.Same as previous ver 1, ver 2 also always runs on top of
MainActor's executor by using custom (replaced withMainActor) executor andActor.assumeIsolatedmethod.MainActomaton2is package-internally used inActomatonUI.Store(Core), so users won't usually notice the difference.