README: Build info; Docs version updated #3613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add note that mbed-cli is needed for building mbed OS; update link to the docs to point to the latest version.
iriark01
reviewed
Jan 19, 2017
| @@ -11,9 +11,9 @@ The current release, along with a selection of previous versions are detailed he | |||
|
|
|||
| ## Getting Started for Developers | |||
|
|
|||
| We have a getting started guide for developers using mbed OS in applications: | |||
| Please note that you will require [mbed-cli](https://github.com/ARMmbed/mbed-cli) to build mbed OS. For more details please read the getting started guide for developers using mbed OS in applications: | |||
There was a problem hiding this comment.
mbed CLI (as a product name; mbed-cli is only the repo name)
| @@ -11,9 +11,9 @@ The current release, along with a selection of previous versions are detailed he | |||
|
|
|||
| ## Getting Started for Developers | |||
|
|
|||
| We have a getting started guide for developers using mbed OS in applications: | |||
| Please note that you will require [mbed CLI](https://github.com/ARMmbed/mbed-cli) to build mbed OS. For more details please read the getting started guide for developers using mbed OS in applications: | |||
There was a problem hiding this comment.
Please add a comma after "details" for consistency with the rest of the docs.
AnotherButler
approved these changes
Jan 19, 2017
|
@bulislaw please avoid marking your own pr as |
|
Fair enough, but It's a README change, no source code was touched. |
|
Furthermore, the CI is required and we cannot merge without it. |
Yeah I know its a bit overkill. But like @theotherjimmy the CIs are required any way. But because its just a docs change we don't have to trigger the |
96B7
0xc0170
added
ready for merge
release-version: 5.3.4
and removed
needs: CI
ready for merge
labels
Jan 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add note that mbed-cli is needed for building mbed OS; update link to the docs to point to the latest version.
Status
READY
CC: @0xc0170 @theotherjimmy