mbed.h - Move to explicit using statements per class #2661
Conversation
This avoids revealing the entire mbed namespace, allowing less-unique names to be used behind the mbed namespace. Additionally this adds an extra step to introducing new names into the global namespace.
149389a to
5bc8761
Compare
|
I don't like this solution. Forcing the use of mbed:: for certain classes/utilities isn't a solution. Its already polluted, accept it and consider it a protection we don't have. I'd prefer that was the mindset as well for new APIs etc... There is too much potentially not exposed by this that previously was which breaks forcing them to add using namespace mbed (same problem exists) or mbed:: (even worse) Haven't looked at the results but CI seems to agree. |
|
This patch looks like would require a bit more work to track down the names that need to be exposed, but it could provide a general solution for avoiding new namespace polution. A put up a more short-term patch as an alternative over here: #2663 |
|
Closing: not planning on looking more into this Feel free to takeover if anyone wants to consider this idea |
This avoids revealing the entire mbed namespace, allowing less-unique names to be used behind the mbed namespace. Additionally this adds an extra step to introducing new names into the global namespace which will hopefully avoid name polution in the future.
should fix #2653
cc @sg-, @bridadan, @tommikas