This repository was archived by the owner on Jan 17, 2023. It is now read-only.
Use low priority queue instead of background for SCNetworkReachabilityGetFlags() #4587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkboo
added a commit
to parkboo/AFNetworking
that referenced
this pull request
Sep 22, 2020
* commit '77ef5fed64d98107acd177a90182163a20ba4567': (31 commits) Use low priority queue instead of background for SCNetworkReachabilityGetFlags() (AFNetworking#4587) Exempt "needs investigation" from stalebot. Only mark unlabeled issues as stale. Loop over only changed keypaths in request serializer (AFNetworking#4581) Disable 'Zombie Objects' diagnostics for tvOS scheme (AFNetworking#4572) Fix docblock for setAuthenticationChallengeHandler (AFNetworking#4574) Fix type in CHANGELOG. (AFNetworking#4562) Prepare 4.0.1 Release (AFNetworking#4555) Fix ServerTrustError crash. (AFNetworking#4553) Fix SPM usage with better publicHeadersPath. (AFNetworking#4554) Replace instead of appending to the default header (AFNetworking#4550) Fix nullability (AFNetworking#4551) Update CHANGELOG.md (AFNetworking#4537) Fix UIKit+AFNetworking.h (AFNetworking#4536) Remove unused UIImage+AFNetworking.h (AFNetworking#4535) Separate bundle identifier for watchOS target (AFNetworking#4533) Fix MobileCoreServices renamed warning, close #4520 (AFNetworking#4532) Add FOUNDATION_EXPORT for AFJSONObjectByRemovingKeysWithNullValues (AFNetworking#4529) (Infra) Make infra changes to cleanup project and simplify its maintenance (AFNetworking#4531) Improve podspec (AFNetworking#4528) ... # Conflicts: # Framework/AFNetworking.h
ElfSundae
added a commit
to ElfSundae/AFNetworking
that referenced
this pull request
Dec 30, 2020
- Use low priority queue instead of background for `SCNetworkReachabilityGetFlags()` (AFNetworking#4587) - Fix redirect test: use httpbingo service instead (AFNetworking#4620)
|
Ok |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Link 🔗
Close #4223, related Alamofire/Alamofire#3207
Background queues may stop execution altogether in low power mode, so utility mode is recommended.
Goals ⚽
This PR changes
DISPATCH_QUEUE_PRIORITY_BACKGROUNDtoDISPATCH_QUEUE_PRIORITY_LOW(maps to theQOS_CLASS_UTILITYclass) forSCNetworkReachabilityGetFlags()in the method-[AFNetworkReachabilityManager startMonitoring].Implementation Details 🚧
DISPATCH_QUEUE_PRIORITY_BACKGROUND->DISPATCH_QUEUE_PRIORITY_LOWTesting Details 🔍
None, there's no way to test this behavior.