Add tlv to require confirmed inputs for dual funding #2461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When that tlv is specified, the peer must use confirmed inputs, otherwise the funding attempt will be rejected. This ensures that we won't pay the fees for a low-feerate ancestor.
This can be configured at two levels: - globally using `eclair.conf` - on a per-channel basis by overriding the default in `Peer.OpenChannel`
When our peer requires us to use only confirmed inputs, we filter unconfirmed inputs as unusable.
pm47
reviewed
Oct 19, 2022
eclair-core/src/main/scala/fr/acinq/eclair/channel/InteractiveTxBuilder.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/ChannelTlv.scala
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/channel/InteractiveTxBuilder.scala
Outdated
Show resolved
Hide resolved
pm47
approved these changes
Oct 19, 2022
t-bast
added a commit
that referenced
this pull request
Sep 5, 2024
Similar to #2461 but for the non-initiator of a channel open.
t-bast
added a commit
that referenced
this pull request
Sep 6, 2024
Similar to #2461 but for the non-initiator of a channel open.
t-bast
added a commit
that referenced
this pull request
Sep 9, 2024
Similar to #2461 but for the non-initiator of a channel open.
t-bast
added a commit
that referenced
this pull request
Sep 12, 2024
Similar to #2461 but for the non-initiator of a channel open.
t-bast
added a commit
that referenced
this pull request
Sep 13, 2024
Similar to #2461 but for the non-initiator of a channel open.
t-bast
added a commit
that referenced
this pull request
Sep 16, 2024
Similar to #2461 but for the non-initiator of a channel open.
t-bast
added a commit
that referenced
this pull request
Sep 24, 2024
Similar to #2461 but for the non-initiator of a channel open.
t-bast
added a commit
that referenced
this pull request
Sep 24, 2024
Similar to #2461 but for the non-initiator of a channel open.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add a tlv to
open_channel2andaccept_channel2to require our peer to only use confirmed inputs, as proposed here. Using only confirmed inputs ensures that we don't end up paying the fees of one of our peer's unconfirmed ancestors.This can be configured at two levels:
eclair.confPeer.OpenChannelThis PR contains a breaking change in the codecs: since dual funding isn't released yet, it's ok to make such a breaking change now: this is why I'd like to integrate this PR now, even though the final value of the TLV isn't specified yet. Updating the TLV can be done later without breaking compatibility.
This PR is probably best reviewed commit-by-commit.