Reject 0-value trampoline payments #1851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't make any sense to forward empty payments. This is also checked when adding the htlcs in the outgoing channel, but we should fail early here.
pm47
approved these changes
Jun 28, 2021
Codecov Report
@@ Coverage Diff @@
## master #1851 +/- ##
==========================================
- Coverage 88.96% 88.94% -0.03%
==========================================
Files 150 150
Lines 11237 11239 +2
Branches 429 447 +18
==========================================
- Hits 9997 9996 -1
- Misses 1240 1243 +3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't make any sense to forward empty payments.
This is also checked when adding the htlcs in the outgoing channel, but we should fail early in the node-relay actor.