10000 Annotation field by mahyar-osn · Pull Request #1 · ABI-Software/mbfxml2ex · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Annotation field #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 4, 2019
Merged

Annotation field #1

merged 9 commits into from
Nov 4, 2019

Conversation

mahyar-osn
Copy link
Member

Adding a new stored string field to the generated EX file when the XML has a 'type' (e.g. Axon or Dendrite) in its .

hsorby
hsorby reviewed Aug 13, 2019
View reviewed changes
Copy link
Collaborator
@hsorby hsorby left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add at least two tests showing:

  1. that the package can handle the 'property' tag
  2. that the package writes out the 'annotation' file into an ex file

(which should have been done before the implementation.)

@hsorby
Copy link
Collaborator
hsorby commented Oct 23, 2019

You need to add some tests for this new code.

hsorby
hsorby requested changes Nov 3, 2019
View reviewed changes
Copy link
Collaborator
@hsorby hsorby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test to check that the annotation you are expecting appears in an output file.

@hsorby
Copy link
Collaborator
hsorby commented Nov 3, 2019

We will need to change this annotation extraction because it would be better to have it put into a separate file that makes statements about the group. But we will leave that for after this PR. One thing that this will mean is that this information will not be available from the ex file in the near future.

@mahyar-osn
Copy link
Member Author

Just made the changes as requested. Additionally, I agree with having a separate file for annotation groups.

@mahyar-osn mahyar-osn requested a review from hsorby November 4, 2019 05:39
@hsorby hsorby merged commit 9dfb334 into ABI-Software:master Nov 4, 2019
hsorby added a commit that referenced this pull request Jun 24, 2024
@hsorby
Merge pull request #1 from mahyar-osn/annotation_field
3248e3d 
Annotation field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsorby hsorby hsorby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mahyar-osn @hsorby
0