8000 Ensure all assertions have CurrentAssertionChain property (#139) by cbersch · Pull Request #138 · AwesomeAssertions/AwesomeAssertions · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Ensure all assertions have CurrentAssertionChain property (#139) #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2025
Merged

Ensure all assertions have CurrentAssertionChain property (#139) #138

merged 1 commit into from
May 6, 2025

Conversation

cbersch
Copy link
Contributor
@cbersch cbersch commented May 4, 2025 •
edited
Loading

Fixes #139

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@cbersch cbersch force-pushed the ensure-assertions-have-currentassertionchain-property branch 2 times, most recently from 4bca2a3 to ee380c8 Compare May 4, 2025 12:32
@coveralls
Copy link
coveralls commented May 4, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 14852802313

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 52 of 52 (100.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.005%) to 97.442%
Totals Coverage Status
Change from base Build 14843237075: -0.005%
Covered Lines: 12467
Relevant Lines: 12651
💛 - Coveralls

@cbersch cbersch force-pushed the ensure-assertions-have-currentassertionchain-property branch from ee380c8 to 54c4b41 Compare May 5, 2025 09:17
@cbersch cbersch marked this pull request as ready for review May 5, 2025 09:55
@cbersch cbersch requested a review from a team May 5, 2025 09:55
@cbersch cbersch changed the title Ensure all assertions have CurrentAssertionChain property (#119) Ensure all assertions have CurrentAssertionChain property (#139) May 5, 2025
IT-VBFK
IT-VBFK approved these changes May 5, 2025
View reviewed changes
Copy link
Contributor
@IT-VBFK IT-VBFK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this :)

Just these few minor comments to address.
Is this worth mentioning in the release notes?

8000
@cbersch cbersch force-pushed the ensure-assertions-have-currentassertionchain-property branch from 54c4b41 to a4a97ed Compare May 6, 2025 06:03
@cbersch
Copy link
Contributor Author
cbersch commented May 6, 2025 •
edited
Loading

Is this worth mentioning in the release notes?

Yes, but as I had three PR open, the releases.md was a known point for conflicts. But probably its still better to have the release notes committed together with the respective changes. I'll add them.

@cbersch cbersch force-pushed the ensure-assertions-have-currentassertionchain-property branch from a4a97ed to b6101b8 Compare May 6, 2025 06:08
@ITaluone
Copy link
Contributor
ITaluone commented May 6, 2025

But probably its still better to have the release notes committed together with the respective changes

Yes, docs and release notes should always be added with the respective PR, so everything stays in sync

@sonarqubecloud SonarQubeCloud
Copy link
sonarqubecloud bot commented May 6, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@cbersch cbersch merged commit 133f58e into AwesomeAssertions:main May 6, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IT-VBFK IT-VBFK IT-VBFK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure all our Assertions have a CurrentAssertionChain property
4 participants
@cbersch @coveralls @ITaluone @IT-VBFK
0