[Notifications Revamp] Add settings banner #4032
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
|
| android:viewportWidth="24" | ||
| android:viewportHeight="24"> | ||
| <path | ||
| android:pathData="M11.958,2C12.982,2 13.812,2.895 13.812,4V4.165C15.757,4.538 17.144,5.521 18.008,6.955C18.686,8.081 18.911,9.199 18.911,10V14.241L21.112,18.514C21.455,19.181 21.008,20 20.301,20H14.738C14.738,21.657 13.493,23 11.957,23C10.421,23 9.176,21.657 9.176,20H3.615C2.908,20 2.461,19.181 2.804,18.514L5.005,14.241V10C5.005,9.199 5.23,8.081 5.908,6.955C6.772,5.521 8.159,4.538 10.104,4.165V4C10.104,2.895 10.934,2 11.958,2ZM11.957,21C11.445,21 11.03,20.552 11.03,20H12.884C12.884,20.552 12.469,21 11.957,21ZM18.726,18L17.173,14.986C17.097,14.837 17.057,14.67 17.057,14.5V10C17.057,9.911 17.039,9.707 16.983,9.431C16.888,8.957 16.717,8.483 16.453,8.045C15.687,6.774 14.288,6 11.958,6C9.628,6 8.229,6.774 7.463,8.045C7.199,8.483 7.028,8.957 6.932,9.431C6.877,9.707 6.859,9.911 6.859,10V14.5C6.859,14.67 6.819,14.837 6.743,14.986L5.19,18H18.726Z" |
Check warning
Code scanning / Android Lint
Long vector paths Warning
MiSikora
requested changes
May 23, 2025
.../com/shiftyjelly/pocketcasts/settings/notifications/components/NotificationSettingsBanner.kt
Outdated
Show resolved
Hide resolved
...java/au/com/shiftyjelly/pocketcasts/settings/notifications/NotificationsSettingsViewModel.kt
Outdated
Show resolved
Hide resolved
...in/java/au/com/shiftyjelly/pocketcasts/settings/notifications/NotificationsSettingsScreen.kt
Outdated
Show resolved
Hide resolved
...in/java/au/com/shiftyjelly/pocketcasts/settings/notifications/NotificationsSettingsScreen.kt
Outdated
Show resolved
Hide resolved
...services/compose/src/main/java/au/com/shiftyjelly/pocketcasts/compose/components/Settings.kt
Show resolved
Hide resolved
e7d13f7 to
d2417c4
Compare
baca31f to
8d834e8
Compare
Base automatically changed from
task/notifications-add-recommendations
to
task/notification-revamp
May 23, 2025 12:17
d2417c4 to
2b224a8
Compare
MiSikora
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding the notification settings banner to the Notification Settings screen when the system notifications permission is not granted.
I have prepared a new component
NotificationSettingsBannerfollowing designs: hVHQ8RgGQf1afBWybZExD2-fi-275_5326I also had to update the existing
SettingRowcomponents to support the new 'disabled' state, applying a transparent overlay with 38% alpha.Testing Instructions
Screenshots or Screencast
Checklist
[ ] If this is a user-facing change, I have added an entry in CHANGELOG.md./gradlew spotlessApplyto automatically apply formatting/linting)modules/services/localization/src/main/res/values/strings.xml[ ] I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.I have tested any UI changes...