fix: add custom site titles #2486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
miguelpeixe
requested changes
Apr 24, 2025
426760a to
20f61ce
Compare
miguelpeixe
approved these changes
May 12, 2025
|
Hey @rbcorrales, good job getting this PR merged! 🎉 Now, the Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label. If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label. Thank you! ❤️ |
matticbot
pushed a commit
that referenced
this pull request
May 23, 2025
## [2.9.1-alpha.1](v2.9.0...v2.9.1-alpha.1) (2025-05-23) ### Bug Fixes * add custom site titles ([#2486](#2486)) ([fc91ed9](fc91ed9)) * add filter to show the update date on post types ([#2484](#2484)) ([ec9c1bf](ec9c1bf)) * **category-links:** adjust category links to handle links in sponsor descriptions ([#2488](#2488)) ([882c271](882c271))
|
🎉 This PR is included in version 2.9.1-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Jun 2, 2025
## [2.9.1](v2.9.0...v2.9.1) (2025-06-02) ### Bug Fixes * add custom site titles ([#2486](#2486)) ([fc91ed9](fc91ed9)) * add filter to show the update date on post types ([#2484](#2484)) ([ec9c1bf](ec9c1bf)) * **category-links:** adjust category links to handle links in sponsor descriptions ([#2488](#2488)) ([882c271](882c271))
|
🎉 This PR is included in version 2.9.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Fixes the site title displayed for multibranded sites. It introduces a new custom site title functionality that allows filtering both the site name and URL using hooks. This is used to address an issue with handling multi-branded site title links, where the rendered URL points to the site's root instead of the brand's root.
The implementation includes:
newspack_site_title()function that supports custom site names and URLs via filters, similar to the existingnewspack_the_custom_logo()function.site-branding.phpto use this new function and avoid duplication.newspack_site_title_name: For filtering the site name that appears within the site title section.newspack_site_title_url: For filtering the home URL that is linked by the site title.newspack_site_title: For filtering the wholenewspack_site_title()function at the end.How 8000 to test the changes in this Pull Request:
newspack_site_title_nameto modify the site name.newspack_site_title_urlto modify the site URL.newspack_site_titleto modify the entire site title HTML.localhost/my-brandinstead of justlocalhost/), just like the header logo link.Other information: