types(connection): add Connection.prototype.bulkWrite() to types #15368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds TypeScript support for Connection.prototype.bulkWrite(), addressing a missing type definition as highlighted in issue #15359. It also strengthens test coverage by adding TS assertions in test/types/connection.test.ts and updates the JavaScript test in test/connection.test.js to verify bulkWrite's return values.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/types/connection.test.ts | Introduces TypeScript tests for the new bulkWrite() method. |
| test/connection.test.js | Updates the bulkWrite() test to capture and assert return values. |
hasezoey
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #15359
Re: #15058
Summary
Missed a spot when adding
Connection.prototype.bulkWrite()support in #15058: need TypeScript types as well.Examples