ci(NODE-6
8000
919): Use mongodb-runner in encryption cluster setup
#15366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
commented
Apr 21, 2025
| /** @type { string } */ | ||
| let clusterUri; | ||
| before(async function() { | ||
| const expansionFile = join(__dirname, '../..', 'fle-cluster-config.json'); |
There was a problem hiding this comment.
Because we now use npm packages to launch clusters, it would be straightforward to setup and teardown the clusters as a part of the test suite. I considered adding this and decided against it, just because the existing usage pattern works well and means you don't need to setup/teardown a cluster per test run locally, but I can add this functionality if it is desirable.
vkarpov15
reviewed
Apr 22, 2025
9049eff to
8a2c374
Compare
|
@vkarpov15 Done. I actually noticed the FLE tests weren't running, because they only run on PR to master, which I've fixed. But they pass now 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR re-writes the existing encryption test setup tooling to use https://www.npmjs.com/package/mongodb-runner and https://www.npmjs.com/package/@mongodb-js/mongodb-downloader.
These packages are tooling packages maintained by teams at MongoDB for use in testing. Use of
npmpackages integrates more seamlessly into Mongoose's existing tooling.