8000 Update Makefile.bat by eldemet · Pull Request #485 · OpenWaterAnalytics/EPANET · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update Makefile.bat #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2019
Merged

Update Makefile.bat #485

merged 1 commit into from
May 13, 2019

Conversation

eldemet
Copy link
Contributor
@eldemet eldemet commented May 12, 2019

Updates on the Microsoft SDK 7.1 compilation script to generate runepanet.exe and to use the \include\epanet2.def

@eladsal, @Mariosmsk can you please check?

Updates on the Microsoft SDK 7.1 compilation script to generate runepanet.exe and to use the \include\epanet2.def
@eldemet eldemet added this to the v2.2 milestone May 12, 2019
@eladsal
Copy link
Member
eladsal commented May 12, 2019
< 8000 tbody class="d-block">

@eldemet so this will replace #484, right? Should I close it?

@codecov-io
Copy link
codecov-io commented May 12, 2019

Codecov Report

Merging #485 into dev will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev     #485      +/-   ##
=========================================
+ Coverage     69%   69.04%   +0.03%     
=========================================
  Files         27       27              
  Lines      10164    10164              
=========================================
+ Hits        7014     7018       +4     
+ Misses      3150     3146       -4
Impacted Files Coverage Δ
src/hydcoeffs.c 78.84% <0%> (+0.25%) ⬆️
src/input2.c 88.7% <0%> (+0.8%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d71776d...8c4aa0e. Read the comment docs.

@eldemet
Copy link
Contributor Author
eldemet commented May 12, 2019

yes!

@Mariosmsk
Copy link
Member

It's ok for merge.

@eladsal eladsal merged commit d0634c9 into dev May 13, 2019
@samhatchett samhatchett deleted the eldemet-patch-1 branch September 25, 2019 17:25
@rjanke20 rjanke20 mentioned this pull request Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0