8000 Eliminates use of temporary linked lists to process Patterns & Curves… by LRossman · Pull Request #450 · OpenWaterAnalytics/EPANET · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Eliminates use of temporary linked lists to process Patterns & Curves… #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 8, 2019
Merged

Eliminates use of temporary linked lists to process Patterns & Curves… #450

merged 2 commits into from
Apr 8, 2019

Conversation

LRossman
Copy link
Collaborator
@LRossman LRossman commented Apr 5, 2019

… (issue #449)

@codecov-io
Copy link
codecov-io commented Apr 5, 2019 •
edited
Loading

Codecov Report

Merging #450 into dev will decrease coverage by 0.15%.
The diff coverage is 90.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #450      +/-   ##
==========================================
- Coverage   69.68%   69.53%   -0.16%     
==========================================
  Files          22       22              
  Lines        9939     9880      -59     
==========================================
- Hits         6926     6870      -56     
+ Misses       3013     3010       -3
Impacted Files Coverage Δ
src/input2.c 88.7% <100%> (+0.33%) ⬆️
src/input1.c 91.94% <100%> (+0.02%) ⬆️
src/input3.c 77.2% <80.95%> (-0.14%) ⬇️
src/epanet.c 58.64% <90.9%> (-0.05%) ⬇️
src/project.c 89.46% <92.3%> (-0.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b87c102...b2a8b55. Read the comment docs.

@Mariosmsk
Copy link
Member
Mariosmsk commented Apr 5, 2019 •
edited
Loading

@LRossman, bug in EN_getcurvetype when I call index 2 for the test INP file BWSN_Network_1.inp (return -2147483648)

@LRossman
Copy link
Collaborator Author
LRossman commented Apr 5, 2019

@Mariosmsk I don't have the BWSN_Network_1.inp file. Could you send me a link to it or maybe post it in a response as a zipped file. Thanks.

@Mariosmsk
Copy link
Member

BWSN_Network_1.zip

@LRossman
Copy link
Collaborator Author
LRossman commented Apr 5, 2019

@Mariosmsk it's been fixed. Thanks for testing it.

@Mariosmsk
Copy link
Member

@LRossman, It's ok. Now returns the code type GENERAL but is the PUMP!

@LRossman
Copy link
Collaborator Author
LRossman commented Apr 6, 2019

@Mariosmsk the curve with index 2 is named CURVE-1. Although the comment attached to it says its a pump curve, if you search the BWSN_Network_1 file you will see that it's not used by any of the pumps, which is how the toolkit determines if a curve is a pump curve or not. Therefore it's designated as a EN_GENERIC_CURVE.

@Mariosmsk
Copy link
Member

@LRossman, yes. So it's ok. Thanks!

@LRossman LRossman merged commit 1f67c8c into dev Apr 8, 2019
@rjanke20 rjanke20 mentioned this pull request Dec 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LRossman @codecov-io @Mariosmsk
0