8000 Spectra are not stored if only meta data is read. by timosachsenberg · Pull Request #5600 · OpenMS/OpenMS · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Spectra are not stored if only meta data is read. #5600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2021
Merged

Spectra are not stored if only meta data is read. #5600

merged 1 commit into from
Oct 19, 2021

Conversation

timosachsenberg
Copy link
Contributor

Description

SpectrumLookup needs properly parsed spectra

Checklist:

  • Make sure that you are listed in the AUTHORS file
  • Add relevant changes and new features to the CHANGELOG file
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes
  • Updated or added python bindings for changed or new classes. (Tick if no updates were necessary.)

How can I get additional information on failed tests during CI:

If your PR is failing you can check out

Note:

  • Once you opened a PR try to minimize the number of pushes to it as every push will trigger CI (automated builds and test) and is rather heavy on our infrastructure (e.g., if several pushes per day are performed).

@timosachsenberg timosachsenberg linked an issue Oct 19, 2021 that may be closed by this pull request
NovorAdapter in OpenMS 2.7.0 ends in error message #5591
Closed
@timosachsenberg timosachsenberg changed the base branch from develop to release/2.7.1 October 19, 2021 13:02
@timosachsenberg timosachsenberg changed the base branch from release/2.7.1 to develop October 19, 2021 13:02
@jpfeuffer
Copy link
Contributor

See also #4905

@timosachsenberg
Copy link
Contributor Author

rebuild jenkins

Waschi97
Waschi97 approved these changes Oct 19, 2021
View reviewed changes
@timosachsenberg timosachsenberg merged commit 5cb7abb into develop Oct 19, 2021
@timosachsenberg timosachsenberg deleted the fix/novor branch October 19, 2021 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpfeuffer jpfeuffer jpfeuffer left review comments

@Waschi97 Waschi97 Waschi97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NovorAdapter in OpenMS 2.7.0 ends in error message
3 participants
@timosachsenberg @jpfeuffer @Waschi97
0